[ios] Removed WEB_TEST_F from web unit tests.

[ios] Removed WEB_TEST_F from web unit tests.

BUG=None

Committed: https://crrev.com/b1487587329131066ed0db7d2429b2b84f281e35
Cr-Commit-Position: refs/heads/master@{#376035}

[Eugene But (OOO till 7-30), 2016-01-28 19:34:52]

eugenebut@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[stuartmorgan, 2016-01-28 22:24:46]

https://codereview.chromium.org/1641893003/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller_unittest.mm (left):

https://codereview.chromium.org/1641893003/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller_unittest.mm:479:
CrWebInvokeWithMessagesFromDifferentWindows) {
Shouldn't we be rewriting this (and maybe some of the other) tests as WKWebView
tests rather than nuking them?

https://codereview.chromium.org/1641893003/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller_unittest.mm:1541: // Tests that
WKWebView does not crash if deallocation happens during JavaScript
I forget, was the fix for this in iOS 9 (meaning we don't need the workaround at
all)?

[Eugene But (OOO till 7-30), 2016-02-02 22:55:02]

https://codereview.chromium.org/1641893003/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller_unittest.mm (left):

https://codereview.chromium.org/1641893003/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller_unittest.mm:479:
CrWebInvokeWithMessagesFromDifferentWindows) {
On 2016/01/28 22:24:46, stuartmorgan wrote:
> Shouldn't we be rewriting this (and maybe some of the other) tests as
WKWebView
> tests rather than nuking them?
How about I file a bug to write those tests? There is not much value in keeping
UIWebView tests around.

https://codereview.chromium.org/1641893003/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller_unittest.mm:1541: // Tests that
WKWebView does not crash if deallocation happens during JavaScript
On 2016/01/28 22:24:46, stuartmorgan wrote:
> I forget, was the fix for this in iOS 9 (meaning we don't need the workaround
at
> all)?
Yes, this crash was fixed in iOS9. Workaround was removed, but I forgot to clean
up tests.

[Eugene But (OOO till 7-30), 2016-02-14 21:02:19]

On 2016/02/02 22:55:02, eugenebut wrote:
>
https://codereview.chromium.org/1641893003/diff/20001/ios/web/web_state/ui/cr...
> File ios/web/web_state/ui/crw_web_controller_unittest.mm (left):
> 
>
https://codereview.chromium.org/1641893003/diff/20001/ios/web/web_state/ui/cr...
> ios/web/web_state/ui/crw_web_controller_unittest.mm:479:
> CrWebInvokeWithMessagesFromDifferentWindows) {
> On 2016/01/28 22:24:46, stuartmorgan wrote:
> > Shouldn't we be rewriting this (and maybe some of the other) tests as
> WKWebView
> > tests rather than nuking them?
> How about I file a bug to write those tests? There is not much value in
keeping
> UIWebView tests around.
> 
>
https://codereview.chromium.org/1641893003/diff/20001/ios/web/web_state/ui/cr...
> ios/web/web_state/ui/crw_web_controller_unittest.mm:1541: // Tests that
> WKWebView does not crash if deallocation happens during JavaScript
> On 2016/01/28 22:24:46, stuartmorgan wrote:
> > I forget, was the fix for this in iOS 9 (meaning we don't need the
workaround
> at
> > all)?
> Yes, this crash was fixed in iOS9. Workaround was removed, but I forgot to
clean
> up tests.

Stuart?

[stuartmorgan, 2016-02-17 14:31:07]

Oops, LGTM. Sorry about that.

I guess there's not much to salvage from these tests since things like the size
limit don't matter now.

[Eugene But (OOO till 7-30), 2016-02-17 23:14:40]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-02-17 23:14:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
stuartmorgan@chromium.org
Link to the patchset: https://codereview.chromium.org/1641893003/#ps40001
(title: "Merged with origin")

[commit-bot: I haz the power, 2016-02-17 23:15:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641893003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641893003/40001

[commit-bot: I haz the power, 2016-02-17 23:50:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-17 23:51:34]

Description was changed from

==========
[ios] Removed WEB_TEST_F from web unit tests.

BUG=None
==========

to

==========
[ios] Removed WEB_TEST_F from web unit tests.

BUG=None

Committed: https://crrev.com/b1487587329131066ed0db7d2429b2b84f281e35
Cr-Commit-Position: refs/heads/master@{#376035}
==========

[commit-bot: I haz the power, 2016-02-17 23:51:35]

Patchset 3 (id:??) landed as
https://crrev.com/b1487587329131066ed0db7d2429b2b84f281e35
Cr-Commit-Position: refs/heads/master@{#376035}