DevTools: [SASS] introduce workspace/cssModel adapter for SASS processor.

DevTools: [SASS] introduce workspace/cssModel adapter for SASS processor.

The WI.SASSWorkspaceAdapter sits atop workspaces and CSSModel and provides
a consise and sufficient API for SASS processor operations.

Methods of WI.SASSWorkspaceAdapter:
- trackSources(sourceMap): WI.SASSWorkspaceAdapter.Client

Methods of The WI.SASSWorkspaceAdapter.Client:
- content(url): Promise<string>
- setCSSText(text, cssEdits): boolean
- setSASSText(url, text): boolean
- isOutdated(): boolean - wheather any sourceMap source has changed
    since last content inquiry.
- dispose()

Events of WI.SASSWorkspaceAdapter.Client:
- SourceChanged(url) - whenever any source of source map gets changed
- TrackingStopped() - whenever the client gets disposed

BUG=527993
R=dgozman

Committed: https://crrev.com/877755e652517055db2247baf8282626757a3812
Cr-Commit-Position: refs/heads/master@{#371996}

[lushnikov, 2016-01-27 20:54:44]

Description was changed from

==========
DevTools: [SASS] introduce workspace/cssModel adapter for SASS processor.

The WI.SASSWorkspaceAdapter sits atop workspaces and CSSModel and provides
a consise and sufficient API for SASS processor operations.

Methods of WI.SASSWorkspaceAdapter:
- trackSources(sourceMap): WI.SASSWorkspaceAdapter.Client

Methods of The WI.SASSWorkspaceAdapter.Client:
- content(url): Promise<string>
- setCSSText(text, cssEdits): boolean
- setSASSText(url, text): boolean
- isOutdated(): boolean - wheather any sourceMap source has changed
    since last content inquiry.
- dispose()

Events of WI.SASSWorkspaceAdapter.Client:
- SourceChanged(url) - whenever any source of source map gets changed
- TrackingStopped(sourceMap) - whenever the client gets disposed

BUG=527993
R=dgozman
==========

to

==========
DevTools: [SASS] introduce workspace/cssModel adapter for SASS processor.

The WI.SASSWorkspaceAdapter sits atop workspaces and CSSModel and provides
a consise and sufficient API for SASS processor operations.

Methods of WI.SASSWorkspaceAdapter:
- trackSources(sourceMap): WI.SASSWorkspaceAdapter.Client

Methods of The WI.SASSWorkspaceAdapter.Client:
- content(url): Promise<string>
- setCSSText(text, cssEdits): boolean
- setSASSText(url, text): boolean
- isOutdated(): boolean - wheather any sourceMap source has changed
    since last content inquiry.
- dispose()

Events of WI.SASSWorkspaceAdapter.Client:
- SourceChanged(url) - whenever any source of source map gets changed
- TrackingStopped() - whenever the client gets disposed

BUG=527993
R=dgozman
==========

[lushnikov, 2016-01-27 20:56:23]

ptal

[dgozman, 2016-01-27 23:14:05]

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js
(right):

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:19: for
(var url of sourceMap.sources()) {
client.sassURLs()

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:25: var
cssPromise = client.content(sourceMap.compiledURL())
client.cssURL()

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:31:
.then(() =>
WebInspector.SASSLiveSourceMap.CSSToSASSMapping.fromSourceMap(sourceMap, cssAST,
sassModels))
Use client.sourceMap() and remove sourceMap parameter.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:32:
.catchException(/** @type {?WebInspector.SASSLiveSourceMap.CSSToSASSMapping}
*/(null))
semicolon missing

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:212: },
revert

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js
(right):

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:1: //
Copyright 2015 The Chromium Authors. All rights reserved.
2016

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:56: *
@return {!WebInspector.SASSWorkspaceAdapter.Client}
WebInspector.SourceMapTracker

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:102:
_sourceCodeForURL: function(url)
sassUISourceCode(url)

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:132:
client.dispose(client);
client.dispose()

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:142:
if (this._cssURLs.has(url) || !this._versions.has(url))
this._isSassURL(url) or comment about it.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:193:
if (this._cssURLs.has(url) || !this._versions.has(url))
isSassURL

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:216:
var newVersion = this._versions.get(url) + 1;
console.assert(this._versions.has(url))

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:267:
console.assert(this._versions.has(url) && !this._cssURLs.has(url), "The url '" +
url + "' should be a tracked SASS url");
isSassURL

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:381:
return !!this._handleContentResponse(result);
this._handleContentResponse(result);
return !!result;

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:1978:
setContent: function(newText, callback)
Should we converge to a single method for setting header's content?

[lushnikov, 2016-01-28 00:04:30]

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js
(right):

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:19: for
(var url of sourceMap.sources()) {
On 2016/01/27 23:14:04, dgozman wrote:
> client.sassURLs()

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:25: var
cssPromise = client.content(sourceMap.compiledURL())
On 2016/01/27 23:14:04, dgozman wrote:
> client.cssURL()

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:31:
.then(() =>
WebInspector.SASSLiveSourceMap.CSSToSASSMapping.fromSourceMap(sourceMap, cssAST,
sassModels))
On 2016/01/27 23:14:04, dgozman wrote:
> Use client.sourceMap() and remove sourceMap parameter.

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:32:
.catchException(/** @type {?WebInspector.SASSLiveSourceMap.CSSToSASSMapping}
*/(null))
On 2016/01/27 23:14:04, dgozman wrote:
> semicolon missing

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSLiveSourceMap.js:212: },
On 2016/01/27 23:14:04, dgozman wrote:
> revert

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js
(right):

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:1: //
Copyright 2015 The Chromium Authors. All rights reserved.
On 2016/01/27 23:14:04, dgozman wrote:
> 2016

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:56: *
@return {!WebInspector.SASSWorkspaceAdapter.Client}
On 2016/01/27 23:14:04, dgozman wrote:
> WebInspector.SourceMapTracker

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:102:
_sourceCodeForURL: function(url)
On 2016/01/27 23:14:04, dgozman wrote:
> sassUISourceCode(url)

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:132:
client.dispose(client);
On 2016/01/27 23:14:04, dgozman wrote:
> client.dispose()

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:142:
if (this._cssURLs.has(url) || !this._versions.has(url))
On 2016/01/27 23:14:04, dgozman wrote:
> this._isSassURL(url) or comment about it.

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:193:
if (this._cssURLs.has(url) || !this._versions.has(url))
On 2016/01/27 23:14:04, dgozman wrote:
> isSassURL

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:216:
var newVersion = this._versions.get(url) + 1;
On 2016/01/27 23:14:04, dgozman wrote:
> console.assert(this._versions.has(url))

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:267:
console.assert(this._versions.has(url) && !this._cssURLs.has(url), "The url '" +
url + "' should be a tracked SASS url");
On 2016/01/27 23:14:04, dgozman wrote:
> isSassURL

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sass/SASSWorkspaceAdapter.js:381:
return !!this._handleContentResponse(result);
On 2016/01/27 23:14:04, dgozman wrote:
> this._handleContentResponse(result);
> return !!result;

Done.

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right):

https://codereview.chromium.org/1641893002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:1978:
setContent: function(newText, callback)
On 2016/01/27 23:14:04, dgozman wrote:
> Should we converge to a single method for setting header's content?

Removed the method altogether.

[lushnikov, 2016-01-28 00:09:21]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 00:11:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641893002/20001

[lushnikov, 2016-01-28 01:11:36]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[dgozman, 2016-01-28 01:11:52]

lgtm

https://codereview.chromium.org/1641893002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/sass/sass-test.js (right):

https://codereview.chromium.org/1641893002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sass/sass-test.js:225: var
styleSheetIds = InspectorTest.cssModel.styleSheetIdsForURL(url)
semicolon missing

https://codereview.chromium.org/1641893002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/sass/test-workspace-adapter.html
(right):

https://codereview.chromium.org/1641893002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sass/test-workspace-adapter.html:34:
setTimeout(InspectorTest.completeTest, 2000);
remove

[commit-bot: I haz the power, 2016-01-28 01:13:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641893002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641893002/40001

[lushnikov, 2016-01-28 01:24:26]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-01-28 01:24:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1641893002/#ps60001
(title: "remove settimeout from test")

[commit-bot: I haz the power, 2016-01-28 01:25:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641893002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641893002/60001

[commit-bot: I haz the power, 2016-01-28 03:44:45]

Description was changed from

==========
DevTools: [SASS] introduce workspace/cssModel adapter for SASS processor.

The WI.SASSWorkspaceAdapter sits atop workspaces and CSSModel and provides
a consise and sufficient API for SASS processor operations.

Methods of WI.SASSWorkspaceAdapter:
- trackSources(sourceMap): WI.SASSWorkspaceAdapter.Client

Methods of The WI.SASSWorkspaceAdapter.Client:
- content(url): Promise<string>
- setCSSText(text, cssEdits): boolean
- setSASSText(url, text): boolean
- isOutdated(): boolean - wheather any sourceMap source has changed
    since last content inquiry.
- dispose()

Events of WI.SASSWorkspaceAdapter.Client:
- SourceChanged(url) - whenever any source of source map gets changed
- TrackingStopped() - whenever the client gets disposed

BUG=527993
R=dgozman
==========

to

==========
DevTools: [SASS] introduce workspace/cssModel adapter for SASS processor.

The WI.SASSWorkspaceAdapter sits atop workspaces and CSSModel and provides
a consise and sufficient API for SASS processor operations.

Methods of WI.SASSWorkspaceAdapter:
- trackSources(sourceMap): WI.SASSWorkspaceAdapter.Client

Methods of The WI.SASSWorkspaceAdapter.Client:
- content(url): Promise<string>
- setCSSText(text, cssEdits): boolean
- setSASSText(url, text): boolean
- isOutdated(): boolean - wheather any sourceMap source has changed
    since last content inquiry.
- dispose()

Events of WI.SASSWorkspaceAdapter.Client:
- SourceChanged(url) - whenever any source of source map gets changed
- TrackingStopped() - whenever the client gets disposed

BUG=527993
R=dgozman
==========

[commit-bot: I haz the power, 2016-01-28 03:44:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-28 03:45:39]

Description was changed from

==========
DevTools: [SASS] introduce workspace/cssModel adapter for SASS processor.

The WI.SASSWorkspaceAdapter sits atop workspaces and CSSModel and provides
a consise and sufficient API for SASS processor operations.

Methods of WI.SASSWorkspaceAdapter:
- trackSources(sourceMap): WI.SASSWorkspaceAdapter.Client

Methods of The WI.SASSWorkspaceAdapter.Client:
- content(url): Promise<string>
- setCSSText(text, cssEdits): boolean
- setSASSText(url, text): boolean
- isOutdated(): boolean - wheather any sourceMap source has changed
    since last content inquiry.
- dispose()

Events of WI.SASSWorkspaceAdapter.Client:
- SourceChanged(url) - whenever any source of source map gets changed
- TrackingStopped() - whenever the client gets disposed

BUG=527993
R=dgozman
==========

to

==========
DevTools: [SASS] introduce workspace/cssModel adapter for SASS processor.

The WI.SASSWorkspaceAdapter sits atop workspaces and CSSModel and provides
a consise and sufficient API for SASS processor operations.

Methods of WI.SASSWorkspaceAdapter:
- trackSources(sourceMap): WI.SASSWorkspaceAdapter.Client

Methods of The WI.SASSWorkspaceAdapter.Client:
- content(url): Promise<string>
- setCSSText(text, cssEdits): boolean
- setSASSText(url, text): boolean
- isOutdated(): boolean - wheather any sourceMap source has changed
    since last content inquiry.
- dispose()

Events of WI.SASSWorkspaceAdapter.Client:
- SourceChanged(url) - whenever any source of source map gets changed
- TrackingStopped() - whenever the client gets disposed

BUG=527993
R=dgozman

Committed: https://crrev.com/877755e652517055db2247baf8282626757a3812
Cr-Commit-Position: refs/heads/master@{#371996}
==========

[commit-bot: I haz the power, 2016-01-28 03:45:39]

Patchset 4 (id:??) landed as
https://crrev.com/877755e652517055db2247baf8282626757a3812
Cr-Commit-Position: refs/heads/master@{#371996}