Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h

Issue 1641853003: Create MediaValuesCached and TokenPreloadScanner on the parser thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TRV_MediaValuesCached
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h
index a583d021e4a2a395dce206c69193d36e9e117086..12628eae11e5f3b691b3bdb80fbb8ce0a70086c0 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h
+++ b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h
@@ -48,26 +48,25 @@ class SegmentedString;
struct CORE_EXPORT CachedDocumentParameters {
USING_FAST_MALLOC(CachedDocumentParameters);
public:
- static PassOwnPtr<CachedDocumentParameters> create(Document* document, PassRefPtrWillBeRawPtr<MediaValuesCached> mediaValues = nullptr)
+ static PassOwnPtr<CachedDocumentParameters> create(Document* document)
{
- return adoptPtr(new CachedDocumentParameters(document, mediaValues));
+ return adoptPtr(new CachedDocumentParameters(document));
}
bool doHtmlPreloadScanning;
- RefPtrWillBeCrossThreadPersistent<MediaValuesCached> mediaValues;
Length defaultViewportMinWidth;
bool viewportMetaZeroValuesQuirk;
bool viewportMetaEnabled;
ReferrerPolicy referrerPolicy;
private:
- CachedDocumentParameters(Document*, PassRefPtrWillBeRawPtr<MediaValuesCached>);
+ CachedDocumentParameters(Document*);
haraken 2016/02/01 11:09:16 Add explicit.
hiroshige 2016/02/06 10:08:44 Done.
};
class TokenPreloadScanner {
WTF_MAKE_NONCOPYABLE(TokenPreloadScanner); USING_FAST_MALLOC(TokenPreloadScanner);
public:
- TokenPreloadScanner(const KURL& documentURL, PassOwnPtr<CachedDocumentParameters>);
+ TokenPreloadScanner(const KURL& documentURL, PassOwnPtr<CachedDocumentParameters>, const MediaValuesCached::MediaValuesCachedData&);
~TokenPreloadScanner();
void scan(const HTMLToken&, const SegmentedString&, PreloadRequestStream& requests);
@@ -80,12 +79,6 @@ public:
TokenPreloadScannerCheckpoint createCheckpoint();
void rewindTo(TokenPreloadScannerCheckpoint);
- bool isSafeToSendToAnotherThread()
- {
- return m_documentURL.isSafeToSendToAnotherThread()
- && m_predictedBaseElementURL.isSafeToSendToAnotherThread();
- }
-
private:
class StartTagScanner;
@@ -135,6 +128,7 @@ private:
PictureData m_pictureData;
size_t m_templateCount;
OwnPtr<CachedDocumentParameters> m_documentParameters;
+ RefPtrWillBePersistent<MediaValuesCached> m_mediaValues;
ClientHintsPreferences m_clientHintsPreferences;
Vector<Checkpoint> m_checkpoints;
@@ -143,19 +137,20 @@ private:
class CORE_EXPORT HTMLPreloadScanner {
WTF_MAKE_NONCOPYABLE(HTMLPreloadScanner); USING_FAST_MALLOC(HTMLPreloadScanner);
public:
- static PassOwnPtr<HTMLPreloadScanner> create(const HTMLParserOptions& options, const KURL& documentURL, PassOwnPtr<CachedDocumentParameters> documentParameters)
+ static PassOwnPtr<HTMLPreloadScanner> create(const HTMLParserOptions& options, const KURL& documentURL, PassOwnPtr<CachedDocumentParameters> documentParameters, const MediaValuesCached::MediaValuesCachedData& mediaValuesCachedData)
{
- return adoptPtr(new HTMLPreloadScanner(options, documentURL, documentParameters));
+ return adoptPtr(new HTMLPreloadScanner(options, documentURL, documentParameters, mediaValuesCachedData));
}
- HTMLPreloadScanner(const HTMLParserOptions&, const KURL& documentURL, PassOwnPtr<CachedDocumentParameters>);
~HTMLPreloadScanner();
void appendToEnd(const SegmentedString&);
void scan(ResourcePreloader*, const KURL& documentBaseElementURL);
private:
+ HTMLPreloadScanner(const HTMLParserOptions&, const KURL& documentURL, PassOwnPtr<CachedDocumentParameters>, const MediaValuesCached::MediaValuesCachedData&);
+
TokenPreloadScanner m_scanner;
SegmentedString m_source;
HTMLToken m_token;

Powered by Google App Engine
This is Rietveld 408576698