Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1641853002: Revert of Consolidate SkStream copying methods (Closed)

Created:
4 years, 11 months ago by msarett
Modified:
4 years, 11 months ago
Reviewers:
hal.canary, scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Consolidate SkStream copying methods (patchset #1 id:1 of https://codereview.chromium.org/1640793002/ ) Reason for revert: Test to see if this fixes the bots. Original issue's description: > Consolidate SkStream copying methods > > Make SkCopyStreamToData call SkStreamCopy, removing duplicate code. > > The former still has its own method of copying with a length, since > it saves one copy. > > BUG=skia:4788 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1640793002 > > Committed: https://skia.googlesource.com/skia/+/440c5a98dee428c661b77d149e30c794d264b8cd TBR=halcanary@google.com,scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4788 Committed: https://skia.googlesource.com/skia/+/553431240b466070aa9937ddfccaba55006af755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/core/SkStream.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of Consolidate SkStream copying methods
4 years, 11 months ago (2016-01-27 20:06:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641853002/1
4 years, 11 months ago (2016-01-27 20:06:12 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 20:06:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/553431240b466070aa9937ddfccaba55006af755

Powered by Google App Engine
This is Rietveld 408576698