Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 1641833002: [tools/perf] Filter out page_cycler.intl_ja_zh/vm_private_dirty_final_renderer metric (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index 9d23cf64f4b3dda4c6335ec4df73f2533422eab0..4feaf5d76684b1139cc9b1b12a0fff7fdc4d8c96 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -96,6 +96,16 @@ class PageCyclerIntlJaZh(_PageCycler):
def Name(cls):
return 'page_cycler.intl_ja_zh'
+ @classmethod
+ def ValueCanBeAddedPredicate(cls, value, is_first_result):
+ # Filter out vm_private_dirty_final_renderer
+ # crbug.com/551522
+ print '**** %s ***' % value.name
+ filtered_name = (
+ 'vm_private_dirty_final_renderer.vm_private_dirty_final_renderer')
+ return (super(PageCyclerIntlJaZh, cls).ValueCanBeAddedPredicate(
+ value, is_first_result) and value.name != filtered_name)
+
@benchmark.Disabled('xp', 'android') # crbug.com/434366, crbug.com/506903
class PageCyclerIntlKoThVi(_PageCycler):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698