Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 164183012: Remove --enable-per-tile-painting and --ui-enable-per-tile-painting. (Closed)

Created:
6 years, 10 months ago by danakj
Modified:
6 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, jbauman+watch_chromium.org, nkostylev+watch_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, danakj+watch_chromium.org, davemoore+watch_chromium.org, jamesr, piman, reveman
Visibility:
Public.

Description

Remove --enable-per-tile-painting and --ui-enable-per-tile-painting. The ui flag is always true on ChromeOS and off elsewhere. The other is never on and we're not planning to turn it on. R=piman@chromium.org, piman BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251538 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252070

Patch Set 1 #

Patch Set 2 : enablepertilepainting: tests #

Patch Set 3 : enablepertilepainting: refptr #

Patch Set 4 : enablepertilepainting: rebase #

Patch Set 5 : enablepertilepainting: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M cc/base/switches.h View 4 1 chunk +0 lines, -2 lines 0 comments Download
M cc/base/switches.cc View 4 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
danakj
6 years, 10 months ago (2014-02-14 23:54:09 UTC) #1
piman
lgtm
6 years, 10 months ago (2014-02-15 00:00:54 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-15 00:08:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/164183012/1
6 years, 10 months ago (2014-02-15 00:18:11 UTC) #4
commit-bot: I haz the power
Change committed as 251538
6 years, 10 months ago (2014-02-15 05:27:50 UTC) #5
xiyuan
A revert of this CL has been created in https://codereview.chromium.org/168423002/ by xiyuan@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-15 07:08:40 UTC) #6
danakj
piman: PTAL This makes the compositor unit tests all pass for me. When per-tile painting ...
6 years, 10 months ago (2014-02-18 22:36:27 UTC) #7
piman
lgtm
6 years, 10 months ago (2014-02-18 23:01:47 UTC) #8
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-18 23:01:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/164183012/410001
6 years, 10 months ago (2014-02-18 23:02:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 01:55:45 UTC) #11
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chromeos/login/chrome_restart_request.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-19 01:55:46 UTC) #12
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-19 16:13:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/164183012/650001
6 years, 10 months ago (2014-02-19 16:15:53 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-19 19:33:39 UTC) #15
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chromeos/login/chrome_restart_request.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-19 19:33:39 UTC) #16
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 10 months ago (2014-02-19 19:37:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/164183012/880001
6 years, 10 months ago (2014-02-19 19:41:46 UTC) #18
danakj
6 years, 10 months ago (2014-02-19 20:47:42 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 manually as r252070 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698