Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 164183004: Files.app: filter out zip archives mounted in other profiles. (Closed)

Created:
6 years, 10 months ago by kinaba
Modified:
6 years, 10 months ago
Reviewers:
mtomasz, hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Files.app: filter out zip archives mounted in other profiles. BUG=336124 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251319

Patch Set 1 : #

Patch Set 2 : Unittest #

Total comments: 4

Patch Set 3 : Review fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -7 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_apitest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 2 3 chunks +57 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager_unittest.cc View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/mount_test/test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
kinaba
6 years, 10 months ago (2014-02-14 04:49:06 UTC) #1
mtomasz
https://codereview.chromium.org/164183004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc File chrome/browser/chromeos/file_manager/volume_manager.cc (right): https://codereview.chromium.org/164183004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc#newcode287 chrome/browser/chromeos/file_manager/volume_manager.cc:287: chain.back().source_path.find(archives[parent].mount_path) == 0) { Does the mount_path contain a ...
6 years, 10 months ago (2014-02-14 05:08:47 UTC) #2
hirono
lgtm with a nit. https://codereview.chromium.org/164183004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc File chrome/browser/chromeos/file_manager/volume_manager_unittest.cc (right): https://codereview.chromium.org/164183004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc#newcode697 chrome/browser/chromeos/file_manager/volume_manager_unittest.cc:697: // Mount a zip archive ...
6 years, 10 months ago (2014-02-14 05:10:43 UTC) #3
kinaba
https://codereview.chromium.org/164183004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc File chrome/browser/chromeos/file_manager/volume_manager.cc (right): https://codereview.chromium.org/164183004/diff/80001/chrome/browser/chromeos/file_manager/volume_manager.cc#newcode287 chrome/browser/chromeos/file_manager/volume_manager.cc:287: chain.back().source_path.find(archives[parent].mount_path) == 0) { On 2014/02/14 05:08:47, mtomasz wrote: ...
6 years, 10 months ago (2014-02-14 05:20:19 UTC) #4
mtomasz
lgtm
6 years, 10 months ago (2014-02-14 05:23:30 UTC) #5
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 10 months ago (2014-02-14 05:28:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/164183004/140001
6 years, 10 months ago (2014-02-14 05:28:23 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:02:09 UTC) #8
Message was sent while issue was closed. 
Change committed as 251319

Powered by Google App Engine
This is Rietveld 408576698