Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/IceInstARM32.cpp

Issue 1641753003: Fix issues raised in CL 1645683003 by stichnot. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index be8488c44e7c4f6e1c898245adb6d977b9290b3c..aac1b9dd0a0fa9945f56011877e10c3b22f22813 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -1067,7 +1067,7 @@ void InstARM32Mov::emitMultiDestSingleSource(const Cfg *Func) const {
assert(DestHi->hasReg());
assert(DestLo->hasReg());
- assert(llvm::isa<Variable>(Src) && Src->hasReg());
+ assert(Src->hasReg());
Str << "\t"
"vmov" << getPredicate() << "\t";
@@ -1167,8 +1167,8 @@ void InstARM32Mov::emitIASScalarVFPMove(const Cfg *Func) const {
assert(false && "Do not know how to emit scalar FP move for type.");
break;
case IceType_f32:
- if (llvm::isa<Variable>(Src0)) {
- Asm->vmovss(Dest, Src0, getPredicate());
+ if (const auto *Var = llvm::dyn_cast<Variable>(Src0)) {
+ Asm->vmovss(Dest, Var, getPredicate());
return;
} else if (const auto *FpImm =
llvm::dyn_cast<OperandARM32FlexFpImm>(Src0)) {
@@ -1178,8 +1178,8 @@ void InstARM32Mov::emitIASScalarVFPMove(const Cfg *Func) const {
assert(!Asm->needsTextFixup());
return;
case IceType_f64:
- if (llvm::isa<Variable>(Src0)) {
- Asm->vmovdd(Dest, Src0, getPredicate());
+ if (const auto *Var = llvm::dyn_cast<Variable>(Src0)) {
+ Asm->vmovdd(Dest, Var, getPredicate());
return;
} else if (const auto *FpImm =
llvm::dyn_cast<OperandARM32FlexFpImm>(Src0)) {
« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698