Fix issues raised in CL 1645683003 by stichnot.

src/IceInstARM32.cpp

 //===- subzero/src/IceInstARM32.cpp - ARM32 instruction implementation ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 1049 matching lines @@
 void InstARM32Mov::emitMultiDestSingleSource(const Cfg *Func) const {
   if (!BuildDefs::dump())
     return;
   Ostream &Str = Func->getContext()->getStrEmit();
   Variable *DestLo = getDest();
   Variable *DestHi = getDestHi();
   auto *Src = llvm::cast<Variable>(getSrc(0));
 
   assert(DestHi->hasReg());
   assert(DestLo->hasReg());
-  assert(llvm::isa<Variable>(Src) && Src->hasReg());
+  assert(Src->hasReg());
 
   Str << "\t"
          "vmov" << getPredicate() << "\t";
   DestLo->emit(Func);
   Str << ", ";
   DestHi->emit(Func);
   Str << ", ";
   Src->emit(Func);
 }
 
@@ skipping 79 matching lines @@
 
 void InstARM32Mov::emitIASScalarVFPMove(const Cfg *Func) const {
   auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
   Operand *Src0 = getSrc(0);
   Variable *Dest = getDest();
   switch (Dest->getType()) {
   default:
     assert(false && "Do not know how to emit scalar FP move for type.");
     break;
   case IceType_f32:
-    if (llvm::isa<Variable>(Src0)) {
-      Asm->vmovss(Dest, Src0, getPredicate());
+    if (const auto *Var = llvm::dyn_cast<Variable>(Src0)) {
+      Asm->vmovss(Dest, Var, getPredicate());
       return;
     } else if (const auto *FpImm =
                    llvm::dyn_cast<OperandARM32FlexFpImm>(Src0)) {
       Asm->vmovs(Dest, FpImm, getPredicate());
       return;
     }
     assert(!Asm->needsTextFixup());
     return;
   case IceType_f64:
-    if (llvm::isa<Variable>(Src0)) {
-      Asm->vmovdd(Dest, Src0, getPredicate());
+    if (const auto *Var = llvm::dyn_cast<Variable>(Src0)) {
+      Asm->vmovdd(Dest, Var, getPredicate());
       return;
     } else if (const auto *FpImm =
                    llvm::dyn_cast<OperandARM32FlexFpImm>(Src0)) {
       Asm->vmovd(Dest, FpImm, getPredicate());
       return;
     }
     assert(!Asm->needsTextFixup());
     return;
   }
   // TODO(kschimpf) Handle register to register move.
@@ skipping 1180 matching lines @@
 
 template class InstARM32FourAddrGPR<InstARM32::Mla>;
 template class InstARM32FourAddrGPR<InstARM32::Mls>;
 
 template class InstARM32CmpLike<InstARM32::Cmn>;
 template class InstARM32CmpLike<InstARM32::Cmp>;
 template class InstARM32CmpLike<InstARM32::Tst>;
 
 } // end of namespace ARM32
 } // end of namespace Ice