Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 1641753002: [turbofan] Stay in optimized code for SMI inputs to %_ToInteger. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Stay in optimized code for SMI inputs to %_ToInteger. We already have this fast case in Crankshaft where we don't call %ToInteger when the input is already a SMI. Add the same optimization to JSIntrinsicLowering. R=jarin@chromium.org Committed: https://crrev.com/0aa00c1b6cfa1ed099ec65c33c9a8a2cb7f36570 Cr-Commit-Position: refs/heads/master@{#33571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +32 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-27 18:33:13 UTC) #1
Benedikt Meurer
Hey Jaro, Here's an easy fix to avoid the runtime call for 99% of the ...
4 years, 11 months ago (2016-01-27 18:38:44 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-01-28 05:14:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641753002/1
4 years, 10 months ago (2016-01-28 05:20:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 05:22:02 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 05:22:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0aa00c1b6cfa1ed099ec65c33c9a8a2cb7f36570
Cr-Commit-Position: refs/heads/master@{#33571}

Powered by Google App Engine
This is Rietveld 408576698