Oilpan: Use CrossThreadPersistent for CanvasAsyncBlobCreator::m_callback

Oilpan: Use CrossThreadPersistent for CanvasAsyncBlobCreator::m_callback

The image encoder runs on a background worker thread, which is not attached to Oilpan.
Thus CanvasAsyncBlobCreator::m_callback touched by the image encoder must use CrossThreadPersistent.

BUG=581877
Committed: https://crrev.com/c29421fa76fb3de2fefc8c792ef48354722a4026
Cr-Commit-Position: refs/heads/master@{#372053}

[haraken, 2016-01-28 04:43:57]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org, sigbjornf@opera.com

[haraken, 2016-01-28 04:43:57]

PTAL

[haraken, 2016-01-28 04:45:34]

haraken@chromium.org changed reviewers:
+ hiroshige@chromium.org

[haraken, 2016-01-28 04:45:34]

hiroshige: Not related to CL, but why doesn't BlobCallback::handleEvent use
threadSafeBind?

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[hiroshige, 2016-01-28 07:46:32]

On 2016/01/28 04:45:34, haraken wrote:
> hiroshige: Not related to CL, but why doesn't BlobCallback::handleEvent use
> threadSafeBind?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Uses of BlobCallback::handleEvent + bind()/threadSafeBind() are inconsistent and
they should be cleaned up.
Probably, this line should be
> Platform::current()->mainThread()->taskRunner()->postTask(BLINK_FROM_HERE,
threadSafeBind(&BlobCallback::handleEvent, m_callback.get(), nullptr));
(I'm not so sure about which functions are called on which thread though).

[sof, 2016-01-28 07:49:07]

lgtm

[haraken, 2016-01-28 08:14:55]

On 2016/01/28 07:46:32, hiroshige wrote:
> On 2016/01/28 04:45:34, haraken wrote:
> > hiroshige: Not related to CL, but why doesn't BlobCallback::handleEvent use
> > threadSafeBind?
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> Uses of BlobCallback::handleEvent + bind()/threadSafeBind() are inconsistent
and
> they should be cleaned up.
> Probably, this line should be
> > Platform::current()->mainThread()->taskRunner()->postTask(BLINK_FROM_HERE,
> threadSafeBind(&BlobCallback::handleEvent, m_callback.get(), nullptr));
> (I'm not so sure about which functions are called on which thread though).

Thanks, makes sense.

[haraken, 2016-01-28 08:14:58]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-01-28 08:15:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641743005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641743005/1

[commit-bot: I haz the power, 2016-01-28 09:17:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-28 09:18:15]

Description was changed from

==========
Oilpan: Use CrossThreadPersistent for CanvasAsyncBlobCreator::m_callback

The image encoder runs on a background worker thread, which is not attached to
Oilpan.
Thus CanvasAsyncBlobCreator::m_callback touched by the image encoder must use
CrossThreadPersistent.

BUG=581877
==========

to

==========
Oilpan: Use CrossThreadPersistent for CanvasAsyncBlobCreator::m_callback

The image encoder runs on a background worker thread, which is not attached to
Oilpan.
Thus CanvasAsyncBlobCreator::m_callback touched by the image encoder must use
CrossThreadPersistent.

BUG=581877

Committed: https://crrev.com/c29421fa76fb3de2fefc8c792ef48354722a4026
Cr-Commit-Position: refs/heads/master@{#372053}
==========

[commit-bot: I haz the power, 2016-01-28 09:18:16]

Patchset 1 (id:??) landed as
https://crrev.com/c29421fa76fb3de2fefc8c792ef48354722a4026
Cr-Commit-Position: refs/heads/master@{#372053}