Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1641743002: PPC: Fix constant pools for tail calls. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix constant pools for tail calls. Constant pool must be marked as unavailable for use after the caller's pointer has been restored ahead of the tail call. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, ishell@chromium.org BUG= Committed: https://crrev.com/71dbee045224310535ad11977c68f58d503838d5 Cr-Commit-Position: refs/heads/master@{#33563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-27 18:00:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641743002/1
4 years, 11 months ago (2016-01-27 18:21:02 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 18:46:36 UTC) #6
michael_dawson
On 2016/01/27 18:46:36, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 11 months ago (2016-01-27 19:22:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641743002/1
4 years, 11 months ago (2016-01-27 19:23:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 19:25:25 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 19:27:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71dbee045224310535ad11977c68f58d503838d5
Cr-Commit-Position: refs/heads/master@{#33563}

Powered by Google App Engine
This is Rietveld 408576698