[interpreter] Translate exception handlers into graph.

[interpreter] Translate exception handlers into graph.

This translates the exception handler table attached to a bytecode array
correctly into exceptional projections within the TurboFan graph. We
perform an abstract simulation of handlers that are being entered and
exited by the bytecode iteration to track the correct handler for each
node.

R=oth@chromium.org
BUG=v8:4674
LOG=n

Committed: https://crrev.com/8bfa1ea33ae51b938af3532d1bebc6b1f6583f9a
Cr-Commit-Position: refs/heads/master@{#33580}

[Michael Starzinger, 2016-01-27 17:23:24]

Description was changed from

==========
[interpreter] Translate exception handlers into graph.

This translates the exception handler table attached to a bytecode array
correctly into exceptional projections within the TurboFan graph. We
perform an abstract simulation of handlers that are being entered and
exited by the bytecode iteration to track the correct handler for each
node.

R=orion@chromium.org
BUG=v8:4674
LOG=n
==========

to

==========
[interpreter] Translate exception handlers into graph.

This translates the exception handler table attached to a bytecode array
correctly into exceptional projections within the TurboFan graph. We
perform an abstract simulation of handlers that are being entered and
exited by the bytecode iteration to track the correct handler for each
node.

R=oth@chromium.org
BUG=v8:4674
LOG=n
==========

[Michael Starzinger, 2016-01-27 17:23:24]

mstarzinger@chromium.org changed reviewers:
+ oth@chromium.org
- orion@chromium.org

[Michael Starzinger, 2016-01-27 17:26:05]

mstarzinger@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Michael Starzinger, 2016-01-27 17:26:06]

Note that tests are still missing. But I wanted to get a first round of comments
on the general direction of this change. Also note that making the
branch-analysis result mutable is hopefully just a temporary solution. I want to
simplify the branch-analysis as a follow-up.

Orion: PTAL.
Michael: FYI.

[mvstanton, 2016-01-28 09:04:43]

Pretty nice, thanks for the capsule explanation yesterday. Y'all are working on
some cool stuff :).

LGTM.

[oth, 2016-01-28 09:25:58]

LGTM. Good set of comments with the code. Looks like one unused declaration, but
super.

https://codereview.chromium.org/1641723002/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1641723002/diff/20001/src/objects.h#newcode4781
src/objects.h:4781: inline int NumberOfReturnEntries() const;
This doesn't appear to have a definition/use.

[Michael Starzinger, 2016-01-28 10:53:56]

Added tests. This is ready for a final review. PTAL.

I had to disable several of the new tests because the branch analysis is giving
me a hard time for handlers that are not reachable (i.e. no throwing node within
the try-range). But I would still like to land this in it's current form and
tackle the branch analysis separately. IMHO the current workaround to the branch
analysis is small enough to be acceptable for now. WDYT?

https://codereview.chromium.org/1641723002/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1641723002/diff/20001/src/objects.h#newcode4781
src/objects.h:4781: inline int NumberOfReturnEntries() const;
On 2016/01/28 09:25:58, oth wrote:
> This doesn't appear to have a definition/use.

Done. Removed.

[oth, 2016-01-28 12:11:26]

Happy to have this land as-is and have refinements to the branch analysis
follow.

[Michael Starzinger, 2016-01-28 12:16:25]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-01-28 12:16:25]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1641723002/#ps60001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-01-28 12:16:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641723002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641723002/60001

[commit-bot: I haz the power, 2016-01-28 12:18:20]

Description was changed from

==========
[interpreter] Translate exception handlers into graph.

This translates the exception handler table attached to a bytecode array
correctly into exceptional projections within the TurboFan graph. We
perform an abstract simulation of handlers that are being entered and
exited by the bytecode iteration to track the correct handler for each
node.

R=oth@chromium.org
BUG=v8:4674
LOG=n
==========

to

==========
[interpreter] Translate exception handlers into graph.

This translates the exception handler table attached to a bytecode array
correctly into exceptional projections within the TurboFan graph. We
perform an abstract simulation of handlers that are being entered and
exited by the bytecode iteration to track the correct handler for each
node.

R=oth@chromium.org
BUG=v8:4674
LOG=n
==========

[commit-bot: I haz the power, 2016-01-28 12:18:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-28 12:18:35]

Description was changed from

==========
[interpreter] Translate exception handlers into graph.

This translates the exception handler table attached to a bytecode array
correctly into exceptional projections within the TurboFan graph. We
perform an abstract simulation of handlers that are being entered and
exited by the bytecode iteration to track the correct handler for each
node.

R=oth@chromium.org
BUG=v8:4674
LOG=n
==========

to

==========
[interpreter] Translate exception handlers into graph.

This translates the exception handler table attached to a bytecode array
correctly into exceptional projections within the TurboFan graph. We
perform an abstract simulation of handlers that are being entered and
exited by the bytecode iteration to track the correct handler for each
node.

R=oth@chromium.org
BUG=v8:4674
LOG=n

Committed: https://crrev.com/8bfa1ea33ae51b938af3532d1bebc6b1f6583f9a
Cr-Commit-Position: refs/heads/master@{#33580}
==========

[commit-bot: I haz the power, 2016-01-28 12:18:35]

Patchset 4 (id:??) landed as
https://crrev.com/8bfa1ea33ae51b938af3532d1bebc6b1f6583f9a
Cr-Commit-Position: refs/heads/master@{#33580}