tools/perf/PRESUBMIT.py - Issue 1641713003: Re-enable android bisect bot for Perf CQ jobs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/PRESUBMIT.py

Issue 1641713003: Re-enable android bisect bot for Perf CQ jobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2012 The Chromium Authors. All rights reserved.	1 # Copyright 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for changes affecting tools/perf/.	5 """Presubmit script for changes affecting tools/perf/.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into depot_tools.	8 for more details about the presubmit API built into depot_tools.

9 """	9 """

10	10

(...skipping 107 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
118 original_description = rietveld_obj.get_description(issue)	118 original_description = rietveld_obj.get_description(issue)

119 if not benchmarks_modified or re.search(	119 if not benchmarks_modified or re.search(

120 r'^CQ_EXTRA_TRYBOTS=.*', original_description, re.M \| re.I):	120 r'^CQ_EXTRA_TRYBOTS=.*', original_description, re.M \| re.I):

121 return []	121 return []

122	122

123 results = []	123 results = []

124 bots = [	124 bots = [

125 'linux_perf_bisect',	125 'linux_perf_bisect',

126 'mac_10_10_perf_bisect',	126 'mac_10_10_perf_bisect',

127 'win_perf_bisect',	127 'win_perf_bisect',

128 # crbug.com/568661, Disable android bots for CQ due to scheduled lab move.	128 'android_nexus5_perf_bisect'

129 # 'android_nexus5_perf_bisect'

130 ]	129 ]

131 bots = ['tryserver.chromium.perf:%s' % s for s in bots]	130 bots = ['tryserver.chromium.perf:%s' % s for s in bots]

132 bots_string = ';'.join(bots)	131 bots_string = ';'.join(bots)

133 description = original_description	132 description = original_description

134 description += '\nCQ_EXTRA_TRYBOTS=%s' % bots_string	133 description += '\nCQ_EXTRA_TRYBOTS=%s' % bots_string

135 results.append(output_api.PresubmitNotifyResult(	134 results.append(output_api.PresubmitNotifyResult(

136 'Automatically added Perf trybots to run Telemetry benchmarks on CQ.'))	135 'Automatically added Perf trybots to run Telemetry benchmarks on CQ.'))

137	136

138 if description != original_description:	137 if description != original_description:

139 rietveld_obj.update_description(issue, description)	138 rietveld_obj.update_description(issue, description)

140	139

141 return results	140 return results

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »