Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: samples/pdfium_test.cc

Issue 1641693003: Fix behaviour of app.alert() with a single object argument. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Fix spelling, naming, braces. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/src/javascript/app.cpp ('k') | testing/resources/javascript/app_alert.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/pdfium_test.cc
diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc
index 164364fbafa040eb3d6612d04475618cd69849c2..3ad0e62626db2390217b0c8e2cfa7a69c6698654 100644
--- a/samples/pdfium_test.cc
+++ b/samples/pdfium_test.cc
@@ -195,10 +195,15 @@ void WriteEmf(FPDF_PAGE page, const char* pdf_name, int num) {
}
#endif
-int ExampleAppAlert(IPDF_JSPLATFORM*, FPDF_WIDESTRING msg, FPDF_WIDESTRING,
- int, int) {
- std::wstring platform_string = GetPlatformWString(msg);
- printf("Alert: %ls\n", platform_string.c_str());
+int ExampleAppAlert(IPDF_JSPLATFORM*,
+ FPDF_WIDESTRING msg,
+ FPDF_WIDESTRING title,
+ int nType,
+ int nIcon) {
+ printf("%ls", GetPlatformWString(title).c_str());
+ if (nIcon || nType)
+ printf("[icon=%d,type=%d]", nIcon, nType);
+ printf(": %ls\n", GetPlatformWString(msg).c_str());
return 0;
}
« no previous file with comments | « fpdfsdk/src/javascript/app.cpp ('k') | testing/resources/javascript/app_alert.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698