Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: fpdfsdk/src/javascript/JS_Value.h

Issue 1641693003: Fix behaviour of app.alert() with a single object argument. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Value.cpp » ('j') | fpdfsdk/src/javascript/JS_Value.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/javascript/JS_Value.h
diff --git a/fpdfsdk/src/javascript/JS_Value.h b/fpdfsdk/src/javascript/JS_Value.h
index 20a6e38b46965e9cac89264d676b634f285b5492..d4a147034bd8d2ff65b1eeb40561338e5f8a23b8 100644
--- a/fpdfsdk/src/javascript/JS_Value.h
+++ b/fpdfsdk/src/javascript/JS_Value.h
@@ -213,4 +213,16 @@ double JS_MakeDate(double day, double time);
bool JS_PortIsNan(double d);
double JS_LocalTime(double d);
+// Some JS methods have the bizzare convention that they may also be called
Lei Zhang 2016/01/28 02:11:11 bizarre
Tom Sepez 2016/01/28 17:07:36 Done.
+// with a single argument which is an object containing the actual arguments
+// as its properties. The varying arguments to this method are the property
+// names as wchar_t string literals corresponding to each positional argument.
+// The result will always contain |nKeywords| value, with unspecified ones
+// being set to type VT_unknown.
+std::vector<CJS_Value> JS_ExpandKeywordParams(
+ CJS_Runtime* pRuntime,
+ const std::vector<CJS_Value>& original_params,
Lei Zhang 2016/01/28 02:11:11 |original_params| -> |originals| to match the impl
Tom Sepez 2016/01/28 17:07:36 Done.
+ size_t nKeywords,
+ ...);
+
#endif // FPDFSDK_SRC_JAVASCRIPT_JS_VALUE_H_
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Value.cpp » ('j') | fpdfsdk/src/javascript/JS_Value.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698