Issue 1641673005: Remove disable_nacl=1 from the nacl download script.

Issue 1641673005: Remove disable_nacl=1 from the nacl download script. (Closed)

Created:
4 years, 10 months ago by dsinclair

Modified:
4 years, 10 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, petrek_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove disable_nacl=1 from the nacl download script. mojo requires nacl to build. Having the build tools silently not download nacl causes confusion. This CL removes the early exit if disable_nacl=1 is set in the GYP_DEFINES. BUG=#639 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4d2ed40dc2390ca98a6fea0580e840535878f11c

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	build/download_nacl_toolchains.py	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 10 (2 generated)

dsinclair

Committed patchset #2 (id:20001) manually as 4d2ed40dc2390ca98a6fea0580e840535878f11c (presubmit successful).

4 years, 10 months ago (2016-01-28 18:47:49 UTC) #5

Sean Klein

On 2016/01/28 18:47:49, dsinclair wrote: > Committed patchset #2 (id:20001) manually as > 4d2ed40dc2390ca98a6fea0580e840535878f11c (presubmit ...

4 years, 10 months ago (2016-01-28 19:04:48 UTC) #6

jamesr

(and why did you land without waiting for green trybots?)

4 years, 10 months ago (2016-01-28 19:05:56 UTC) #8

dsinclair

On 2016/01/28 19:05:56, jamesr wrote: > (and why did you land without waiting for green ...

4 years, 10 months ago (2016-01-28 20:47:33 UTC) #9

jamesr

4 years, 10 months ago (2016-01-28 20:50:31 UTC) #10

Message was sent while issue was closed.

Turns out it wasn't this patch, but still a really bad idea to land with red
trybots.