Add use counters for how often we encounter html comments in scripts

Add use counters for how often we encounter html comments in scripts

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/4a2f3ee8002d2b062efaf2ff05ad0d6f3e819cb3
Cr-Commit-Position: refs/heads/master@{#33561}

[Yang, 2016-01-27 15:54:43]

On 2016/01/27 15:33:00, jochen wrote:

lgtm.

[jochen (gone - plz use gerrit), 2016-01-27 15:55:00]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-01-27 15:55:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641673002/1

[commit-bot: I haz the power, 2016-01-27 15:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 15:57:50]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10218)

[Yang, 2016-01-27 16:16:22]

On 2016/01/27 15:57:50, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10218)

Can you change this so that the counter is only incremented if parsed by
ParseProgram? Otherwise we might overcount due to lazy parsing.
Then again I'm not sure you would count html comments in inner functuons
correctly if we lazily parse the whole script.

[jochen (gone - plz use gerrit), 2016-01-27 17:13:07]

On 2016/01/27 at 16:16:22, yangguo wrote:
> On 2016/01/27 15:57:50, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   v8_presubmit on tryserver.v8 (JOB_FAILED,
> > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10218)
> 
> Can you change this so that the counter is only incremented if parsed by
ParseProgram? Otherwise we might overcount due to lazy parsing.
> Then again I'm not sure you would count html comments in inner functuons
correctly if we lazily parse the whole script.

that doesn't really matter, as on the blink side, the use counters are
deduplicated per page load, ie, whether we report a feature once per page load
or a million times doesn't matter

[jochen (gone - plz use gerrit), 2016-01-27 17:19:15]

jochen@chromium.org changed reviewers:
+ adamk@chromium.org

[jochen (gone - plz use gerrit), 2016-01-27 17:19:31]

Adam, I need a rubberstamp please

[adamk, 2016-01-27 18:11:40]

lgtm for parsing

[jochen (gone - plz use gerrit), 2016-01-27 18:14:30]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-01-27 18:14:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641673002/1

[commit-bot: I haz the power, 2016-01-27 18:18:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 18:19:29]

Description was changed from

==========
Add use counters for how often we encounter html comments in scripts

R=yangguo@chromium.org
BUG=
==========

to

==========
Add use counters for how often we encounter html comments in scripts

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/4a2f3ee8002d2b062efaf2ff05ad0d6f3e819cb3
Cr-Commit-Position: refs/heads/master@{#33561}
==========

[commit-bot: I haz the power, 2016-01-27 18:19:30]

Patchset 1 (id:??) landed as
https://crrev.com/4a2f3ee8002d2b062efaf2ff05ad0d6f3e819cb3
Cr-Commit-Position: refs/heads/master@{#33561}