Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1641653005: [turbofan] Frame elision only for stubs. (Closed)

Created:
4 years, 10 months ago by Mircea Trofin
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

We want to enable frame elision for stubs and bytecode handlers. Disabling it for anything else, to avoid compile time overhead. BUG= Committed: https://crrev.com/9c4d1396b65202135c6dc8abbe253248d183a1b5 Cr-Commit-Position: refs/heads/master@{#33587}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/compiler/pipeline.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
https://codereview.chromium.org/1641653005/diff/1/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/1641653005/diff/1/src/compiler/pipeline.cc#newcode1445 src/compiler/pipeline.cc:1445: if (FLAG_turbo_frame_elision && info()->IsStub()) { Is there a way ...
4 years, 10 months ago (2016-01-28 02:39:10 UTC) #3
Jarin
lgtm
4 years, 10 months ago (2016-01-28 08:32:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641653005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641653005/1
4 years, 10 months ago (2016-01-28 15:22:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 15:24:08 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 15:24:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c4d1396b65202135c6dc8abbe253248d183a1b5
Cr-Commit-Position: refs/heads/master@{#33587}

Powered by Google App Engine
This is Rietveld 408576698