Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 164165: Binaries for chromium built with O2 and static pthread lib linked into avcode... (Closed)

Created:
11 years, 4 months ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, scherkus (not reviewing), fbarchard, awong, kylep
Visibility:
Public.

Description

Binaries for chromium built updated OGG, and reduced in size with O2 and static pthread lib linked into avcodec. BUG=17174, 18466, 16010 TEST=play http://people.xiph.org/~tterribe/tmp/sign_irene_cif-3qi.ogg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22816

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, -166 lines) Patch
M chrome/installer/mini_installer/chrome.release View 1 chunk +0 lines, -1 line 0 comments Download
MM third_party/ffmpeg/binaries/chromium/avcodec-52.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/ffmpeg/binaries/chromium/avformat-52.dll View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/ffmpeg/binaries/chromium/avutil-50.dll View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/ffmpeg/binaries/chromium/pthreadGC2.dll View 3 1 chunk +0 lines, -168 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fbarchard
First draft of new binaries is just the binaries for static link of pthread and ...
11 years, 4 months ago (2009-08-07 19:32:04 UTC) #1
fbarchard
The patch is too large Not uploading the patch for third_party/ffmpeg/binaries/chromium/avcodec-52.dll because the file is ...
11 years, 4 months ago (2009-08-07 19:46:30 UTC) #2
Alpha Left Google
If you mark those files as binary they would appear in the list but won' ...
11 years, 4 months ago (2009-08-07 20:25:10 UTC) #3
fbarchard
Marked as binary svn ps svn:mime-type application/octet-stream avcodec-52.dll svn ps svn:mime-type application/octet-stream avformat-52.dll svn ps ...
11 years, 4 months ago (2009-08-07 21:20:37 UTC) #4
awong
LGTM
11 years, 4 months ago (2009-08-07 21:32:52 UTC) #5
Alpha Left Google
LGTM
11 years, 4 months ago (2009-08-07 21:56:21 UTC) #6
fbarchard
11 years, 4 months ago (2009-08-07 22:51:13 UTC) #7
removed pthread from installer

Powered by Google App Engine
This is Rietveld 408576698