Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1641643004: Roll analyzer to 0.27.2-alpha.1 (Closed)

Created:
4 years, 10 months ago by vsm
Modified:
4 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rerun tests and format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -486 lines) Patch
M lib/runtime/dart/_isolate_helper.js View 3 chunks +10 lines, -10 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 4 chunks +5 lines, -5 lines 0 comments Download
M lib/runtime/dart/async.js View 28 chunks +65 lines, -70 lines 0 comments Download
M lib/runtime/dart/collection.js View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/convert.js View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/html.js View 7 chunks +19 lines, -19 lines 0 comments Download
M lib/runtime/dart/html_common.js View 3 chunks +5 lines, -5 lines 0 comments Download
M lib/runtime/dart/js.js View 4 chunks +6 lines, -6 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 4 chunks +4 lines, -7 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/algorithms.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/canonicalized_map.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/equality.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/iterable_zip.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/priority_queue.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M test/codegen/expect/collection/src/queue_list.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/collection/src/wrappers.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M test/codegen/expect/constructors.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/expect.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/expect/expect.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/language-all.js View Binary file 0 comments Download
M test/codegen/expect/misc.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/expect/unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/unittest/unittest.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tool/sdk_expected_errors.txt View 3 chunks +317 lines, -318 lines 0 comments Download
M tool/test.sh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
4 years, 10 months ago (2016-01-28 23:24:02 UTC) #2
Jennifer Messerly
lgtm
4 years, 10 months ago (2016-01-28 23:34:42 UTC) #3
vsm
4 years, 10 months ago (2016-01-28 23:36:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ad61c17244b7deace4e1a957ebbb8372161ee75b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698