Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 164163002: Delete Geolocation feature flag and switch (Closed)

Created:
6 years, 10 months ago by Michael van Ouwerkerk
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Delete Geolocation command line switch and callers of enableGeolocation. The Geolocation API was launched a long time ago, and a mock is used in layout tests. There are no unit tests so nothing needs to be set for them. BUG=343592, 36451 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251340

Patch Set 1 #

Patch Set 2 : More cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/test_webkit_platform_support.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Michael van Ouwerkerk
6 years, 10 months ago (2014-02-13 17:54:16 UTC) #1
Peter Beverloo
Please also remove the uses from: content/public/common/content_switches.h content/browser/renderer_host/render_process_host_impl.cc
6 years, 10 months ago (2014-02-13 17:57:28 UTC) #2
Michael van Ouwerkerk
On 2014/02/13 17:57:28, Peter Beverloo wrote: > Please also remove the uses from: > content/public/common/content_switches.h ...
6 years, 10 months ago (2014-02-13 18:02:29 UTC) #3
Peter Beverloo
lgtm Assuming the bots are happy, please close http://crbug.com/36451 too. Thanks!
6 years, 10 months ago (2014-02-13 18:10:18 UTC) #4
Michael van Ouwerkerk
Thanks Peter, adding Jochen as owner.
6 years, 10 months ago (2014-02-13 18:20:19 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-14 09:52:08 UTC) #6
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 10 months ago (2014-02-14 11:27:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/164163002/50001
6 years, 10 months ago (2014-02-14 11:27:53 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 13:40:54 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=202213
6 years, 10 months ago (2014-02-14 13:40:54 UTC) #10
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 10 months ago (2014-02-14 14:55:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/164163002/50001
6 years, 10 months ago (2014-02-14 14:56:24 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 16:00:42 UTC) #13
Message was sent while issue was closed.
Change committed as 251340

Powered by Google App Engine
This is Rietveld 408576698