src/unicode.h - Issue 1641613002: [regexp] implement /ui to mirror the implementation for /i.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/unicode.h

Issue 1641613002: [regexp] implement /ui to mirror the implementation for /i. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: addressed comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/unicode.h

diff --git a/src/unicode.h b/src/unicode.h

index 7471a638c045d169e58bceae78087615b06202a9..2d7f995a68fdcc3a4567902a1f750a3ed6eec77a 100644

--- a/src/unicode.h

+++ b/src/unicode.h

@@ -15,8 +15,8 @@

namespace unibrow {

-typedef unsigned int uchar;

-typedef unsigned char byte;

+typedef int32_t uchar;

+typedef uint8_t byte;

/**

* The max length of the result of converting the case of a single

@@ -130,7 +130,7 @@ class Utf16 {

class Utf8 {

public:

- static inline uchar Length(uchar chr, int previous);

+ static inline unsigned Length(uchar chr, int previous);

static inline unsigned EncodeOneByte(char* out, uint8_t c);

static inline unsigned Encode(char* out,

uchar c,

« no previous file with comments | « src/regexp/regexp-parser.cc ('k') | test/cctest/test-strings.cc » ('j') | no next file with comments »