Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1641593002: [regexp] character class for desugaring cannot be part of RegExpText. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] character class for desugaring cannot be part of RegExpText. We only do the desugaring in RegExpCharacterClass::ToNode, which is not called if it is part of a RegExpText. R=erik.corry@gmail.com, erikcorry@chromium.org Committed: https://crrev.com/f22a5663a6382aaf28ba9e412874592bc3468c15 Cr-Commit-Position: refs/heads/master@{#33543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/regexp/regexp-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/regexp-parser.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M test/mjsunit/harmony/unicode-regexp-ignore-case.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years, 10 months ago (2016-01-27 10:07:25 UTC) #1
erikcorry
lgtm
4 years, 10 months ago (2016-01-27 10:19:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641593002/1
4 years, 10 months ago (2016-01-27 10:20:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-27 11:06:35 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-27 11:07:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f22a5663a6382aaf28ba9e412874592bc3468c15
Cr-Commit-Position: refs/heads/master@{#33543}

Powered by Google App Engine
This is Rietveld 408576698