chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc - Issue 1641563002: Remove linked_ptr usage in //base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc

Issue 1641563002: Remove linked_ptr usage in //base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/threading/sequenced_worker_pool.cc ('K') | « base/threading/sequenced_worker_pool.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h » ('j') | components/guest_view/browser/guest_view_base.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc

diff --git a/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc b/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc

index 3e6f560fa22287a9a40a1a99e56e6595cecb419b..981a8e3b70b4df5f88e15894b22a7f3e8204a6dd 100644

--- a/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc

+++ b/chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc

@@ -146,9 +146,8 @@ bool ChromeWebViewInternalShowContextMenuFunction::RunAsyncSafe(

webview::ShowContextMenu::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

- // TODO(lazyboy): Actually implement filtering menu items, we pass NULL for

- // now.

- guest->ShowContextMenu(params->request_id, NULL);

dcheng 2016/01/27 22:18:27 The semantics for this aren't clear. Since it's no

+ // TODO(lazyboy): Actually implement filtering menu items.

+ guest->ShowContextMenu(params->request_id);

SendResponse(true);

return true;