Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: base/supports_user_data.cc

Issue 1641563002: Remove linked_ptr usage in //base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/supports_user_data.cc
diff --git a/base/supports_user_data.cc b/base/supports_user_data.cc
index 9689014d4ad8ebe08b487e228f7fa67b6e052e7f..482a7e1ed61d82c08365a33ce187dab105c069ba 100644
--- a/base/supports_user_data.cc
+++ b/base/supports_user_data.cc
@@ -21,7 +21,7 @@ SupportsUserData::Data* SupportsUserData::GetUserData(const void* key) const {
void SupportsUserData::SetUserData(const void* key, Data* data) {
danakj 2016/01/27 22:20:51 can you make this function take scoped_ptr<Data>?
dcheng 2016/01/27 22:26:01 There's 100+ usages of this, I was hoping that cou
danakj 2016/01/27 22:28:31 I suppose. base/ LGTM scoped_ptr is better than li
dcheng 2016/01/27 22:30:30 Don't think so, I can create one. There's a couple
DCHECK(thread_checker_.CalledOnValidThread());
- user_data_[key] = linked_ptr<Data>(data);
+ user_data_[key] = make_scoped_ptr(data);
}
void SupportsUserData::RemoveUserData(const void* key) {

Powered by Google App Engine
This is Rietveld 408576698