Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 1641563002: Remove linked_ptr usage in //base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rebase, really Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
index f594ade9b2630e53a5138f14152cfa2356f9ff51..9f3c07af53e48b505f821c24747a125b91e4ca89 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
@@ -127,8 +127,8 @@ void ExtensionOptionsGuest::DidInitialize(
void ExtensionOptionsGuest::GuestViewDidStopLoading() {
scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
- DispatchEventToView(new GuestViewEvent(
- extension_options_internal::OnLoad::kEventName, std::move(args)));
+ DispatchEventToView(make_scoped_ptr(new GuestViewEvent(
+ extension_options_internal::OnLoad::kEventName, std::move(args))));
}
const char* ExtensionOptionsGuest::GetAPINamespace() const {
@@ -148,9 +148,9 @@ void ExtensionOptionsGuest::OnPreferredSizeChanged(const gfx::Size& pref_size) {
// Convert the size from physical pixels to logical pixels.
options.width = PhysicalPixelsToLogicalPixels(pref_size.width());
options.height = PhysicalPixelsToLogicalPixels(pref_size.height());
- DispatchEventToView(new GuestViewEvent(
+ DispatchEventToView(make_scoped_ptr(new GuestViewEvent(
extension_options_internal::OnPreferredSizeChanged::kEventName,
- options.ToValue()));
+ options.ToValue())));
}
bool ExtensionOptionsGuest::ShouldHandleFindRequestsForEmbedder() const {
@@ -180,9 +180,9 @@ WebContents* ExtensionOptionsGuest::OpenURLFromTab(
}
void ExtensionOptionsGuest::CloseContents(WebContents* source) {
- DispatchEventToView(
+ DispatchEventToView(make_scoped_ptr(
new GuestViewEvent(extension_options_internal::OnClose::kEventName,
- make_scoped_ptr(new base::DictionaryValue())));
+ make_scoped_ptr(new base::DictionaryValue()))));
}
bool ExtensionOptionsGuest::HandleContextMenu(

Powered by Google App Engine
This is Rietveld 408576698