Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1641553004: Disable verbose mode for DNG SDK on mac/ios. (Closed)

Created:
4 years, 10 months ago by adaubert
Modified:
4 years, 10 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org, yujieqin
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable verbose mode for DNG SDK on mac/ios. The issue was, that the qDNGReportErrors was not disabled in xcode_settings. With that also removed the complexety of the dng_sdk.gyp and unified the flags handling. BUG=26821211 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641553004 Committed: https://skia.googlesource.com/skia/+/382f8bdbf0698d80c2cc64112205ab18aafab2dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -243 lines) Patch
M gyp/dng_sdk.gyp View 2 chunks +179 lines, -243 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641553004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641553004/1
4 years, 10 months ago (2016-01-28 09:03:22 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-01-28 09:03:23 UTC) #4
adaubert
4 years, 10 months ago (2016-01-28 09:18:47 UTC) #6
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from ...
4 years, 10 months ago (2016-01-28 15:03:08 UTC) #8
msarett
LGTM
4 years, 10 months ago (2016-01-28 15:21:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641553004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641553004/1
4 years, 10 months ago (2016-01-28 15:55:28 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 15:56:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/382f8bdbf0698d80c2cc64112205ab18aafab2dd

Powered by Google App Engine
This is Rietveld 408576698