chrome/browser/ui/webui/md_history_ui.cc - Issue 1641543002: MD History: Refactored design for displaying history information

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/md_history_ui.cc

Issue 1641543002: MD History: Refactored design for displaying history information (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@second_patch

Patch Set: Address reviewer's comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/history_list.js ('K') | « chrome/browser/resources/md_history/history_list.js ('k') | chrome/test/data/webui/md_history/history_card_manager_test.js » ('j') | chrome/test/data/webui/md_history/history_card_manager_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/md_history_ui.cc

diff --git a/chrome/browser/ui/webui/md_history_ui.cc b/chrome/browser/ui/webui/md_history_ui.cc

index 49ae383b54b02cc0f74db484d3b45afaadb31b0e..fb16e8341c3b250f64385aca1c5932537078c123 100644

--- a/chrome/browser/ui/webui/md_history_ui.cc

+++ b/chrome/browser/ui/webui/md_history_ui.cc

@@ -37,16 +37,12 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource() {

source->AddLocalizedString("search", IDS_MD_HISTORY_SEARCH);

source->AddLocalizedString("title", IDS_HISTORY_TITLE);

- source->AddResourcePath("history_card.html",

- IDR_MD_HISTORY_HISTORY_CARD_HTML);

- source->AddResourcePath("history_card.js", IDR_MD_HISTORY_HISTORY_CARD_JS);

- source->AddResourcePath("history_card_manager.html",

- IDR_MD_HISTORY_HISTORY_CARD_MANAGER_HTML);

- source->AddResourcePath("history_card_manager.js",

- IDR_MD_HISTORY_HISTORY_CARD_MANAGER_JS);

source->AddResourcePath("history_item.html",

IDR_MD_HISTORY_HISTORY_ITEM_HTML);

source->AddResourcePath("history_item.js", IDR_MD_HISTORY_HISTORY_ITEM_JS);

+ source->AddResourcePath("history_list.html",

+ IDR_MD_HISTORY_HISTORY_LIST_HTML);

+ source->AddResourcePath("history_list.js", IDR_MD_HISTORY_HISTORY_LIST_JS);

source->AddResourcePath("history_toolbar.html",

IDR_MD_HISTORY_HISTORY_TOOLBAR_HTML);

source->AddResourcePath("history_toolbar.js",