Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: gyp/codec.gyp

Issue 1641533004: Enable RAW codec for Windows (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | gyp/dng_sdk.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/codec.gyp
diff --git a/gyp/codec.gyp b/gyp/codec.gyp
index d7272e2a7a9b80f340aa209e1b865151d9fbb09a..eb87de1faa04e4bfd660cdd26de7a091830e60c2 100644
--- a/gyp/codec.gyp
+++ b/gyp/codec.gyp
@@ -67,8 +67,8 @@
'TURBO_HAS_SKIP',
],
'conditions': [
- # FIXME: fix the support for Windows. (Issue with _hypot in DNG SDK).
- ['skia_codec_decodes_raw and skia_os != "win" and skia_os != "chromeos"', {
+ # FIXME: fix the support for ChromeOS [DNG SDK issue with clock_gettime()].
+ ['skia_codec_decodes_raw and skia_os != "chromeos"', {
scroggo 2016/01/27 16:40:22 I think a better fix for this is to not define ski
'dependencies': [
'raw_codec',
],
@@ -89,6 +89,13 @@
'cflags':[
'-fexceptions',
],
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ # Need this because we are handling exception in SkRawCodec, which will trigger warning
+ # C4530. Add this flag as suggested by the compiler.
+ 'AdditionalOptions': ['/EHsc', ],
+ },
+ },
'include_dirs': [
'../include/codec',
'../include/private',
« no previous file with comments | « DEPS ('k') | gyp/dng_sdk.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698