Enable RAW codec for Windows

Enable RAW codec for Windows

* Use new DNG SDK version from ASOP, which fixed some build issues.
* Fix SkRawCodec.
* Fix gyp files.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641533004

Committed: https://skia.googlesource.com/skia/+/076d83d09a5717913cfecabac0440b6c854ca86d

[yujieqin, 2016-01-27 13:20:17]

Description was changed from

==========
Enable RAW codec for Windows

BUG=skia:
==========

to

==========
Enable RAW codec for Windows

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[yujieqin, 2016-01-27 13:21:14]

Description was changed from

==========
Enable RAW codec for Windows

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Enable RAW codec for Windows

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-01-27 14:25:47]

msarett@google.com changed reviewers:
+ msarett@google.com

[msarett, 2016-01-27 14:25:48]

Seems really strange.

You might try copying this block to also be in the dng_srcs target:

  'msvs_settings': {
    'VCCLCompilerTool': {
      'WarningLevel': '0',
    },
  },

Or maybe adding it to a target_defaults block for the whole file?

I also would grep for msvs or msvs_settings in the gyp folder to see if anyone
has solved a similar problem.

I'm not a gyp expert, but most of the time trial and error has worked for me :).

[yujieqin, 2016-01-27 15:33:28]

Description was changed from

==========
Enable RAW codec for Windows

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Enable RAW codec for Windows

* Use new DNG SDK version from ASOP, which fixed some build issues.
* Fix SkRawCodec.
* Fix gyp files.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[yujieqin, 2016-01-27 15:50:46]

Now I use 'AdditionalOptions': ['/wd4189', ], it works. 

I think the reason why the other ways does work could related to the
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/g....

[yujieqin, 2016-01-27 15:52:12]

yujieqin@google.com changed reviewers:
+ scroggo@google.com

[msarett, 2016-01-27 15:57:23]

lgtm

https://codereview.chromium.org/1641533004/diff/200001/gyp/codec.gyp
File gyp/codec.gyp (right):

https://codereview.chromium.org/1641533004/diff/200001/gyp/codec.gyp#newcode94
gyp/codec.gyp:94: 'AdditionalOptions': ['/EHsc', ],
nit: Please comment on why this is necessary.  I ask because I think it's
interesting.

[yujieqin, 2016-01-27 16:05:57]

https://codereview.chromium.org/1641533004/diff/200001/gyp/codec.gyp
File gyp/codec.gyp (right):

https://codereview.chromium.org/1641533004/diff/200001/gyp/codec.gyp#newcode94
gyp/codec.gyp:94: 'AdditionalOptions': ['/EHsc', ],
On 2016/01/27 15:57:23, msarett wrote:
> nit: Please comment on why this is necessary.  I ask because I think it's
> interesting.

Done.

[yujieqin, 2016-01-27 16:06:35]

The CQ bit was checked by yujieqin@google.com

[yujieqin, 2016-01-27 16:06:35]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com
Link to the patchset: https://codereview.chromium.org/1641533004/#ps240001
(title: "rebase")

[commit-bot: I haz the power, 2016-01-27 16:06:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641533004/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641533004/240001

[msarett, 2016-01-27 16:07:03]

LGTM

[commit-bot: I haz the power, 2016-01-27 16:25:55]

Description was changed from

==========
Enable RAW codec for Windows

* Use new DNG SDK version from ASOP, which fixed some build issues.
* Fix SkRawCodec.
* Fix gyp files.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Enable RAW codec for Windows

* Use new DNG SDK version from ASOP, which fixed some build issues.
* Fix SkRawCodec.
* Fix gyp files.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/076d83d09a5717913cfecabac0440b6c854ca86d
==========

[commit-bot: I haz the power, 2016-01-27 16:25:56]

Committed patchset #13 (id:240001) as
https://skia.googlesource.com/skia/+/076d83d09a5717913cfecabac0440b6c854ca86d

[scroggo, 2016-01-27 16:40:22]

https://codereview.chromium.org/1641533004/diff/240001/gyp/codec.gyp
File gyp/codec.gyp (right):

https://codereview.chromium.org/1641533004/diff/240001/gyp/codec.gyp#newcode71
gyp/codec.gyp:71: ['skia_codec_decodes_raw and skia_os != "chromeos"', {
I think a better fix for this is to not define skia_codec_decodes_raw on
chromeos.

(An even better fix, obviously, is to fix it on chromeos :))

[yujieqin, 2016-01-27 16:58:12]

On 2016/01/27 16:40:22, scroggo wrote:
> https://codereview.chromium.org/1641533004/diff/240001/gyp/codec.gyp
> File gyp/codec.gyp (right):
> 
> https://codereview.chromium.org/1641533004/diff/240001/gyp/codec.gyp#newcode71
> gyp/codec.gyp:71: ['skia_codec_decodes_raw and skia_os != "chromeos"', {
> I think a better fix for this is to not define skia_codec_decodes_raw on
> chromeos.
> 
> (An even better fix, obviously, is to fix it on chromeos :))

Yep, I am working on fixing it on chromeos. Just need to fix the dng sdk
somehow.

[yujieqin, 2016-01-28 11:54:25]

On 2016/01/27 16:40:22, scroggo wrote:
> https://codereview.chromium.org/1641533004/diff/240001/gyp/codec.gyp
> File gyp/codec.gyp (right):
> 
> https://codereview.chromium.org/1641533004/diff/240001/gyp/codec.gyp#newcode71
> gyp/codec.gyp:71: ['skia_codec_decodes_raw and skia_os != "chromeos"', {
> I think a better fix for this is to not define skia_codec_decodes_raw on
> chromeos.
> 
> (An even better fix, obviously, is to fix it on chromeos :))

One question, is that possible for me to test the ChromeOS build locally? I
found a folder in the platform_tools/chromeos/bin/, but not sure how to use the
tools.

[msarett, 2016-01-28 15:43:32]

msarett@google.com changed reviewers:
+ borenet@google.com

[msarett, 2016-01-28 15:43:32]

You should be able to run:

./platform_tools/chromeos/bin/chromeos_make -d daisy

I'm getting an "AccessDeniedException: 403 Forbidden", but I'm guessing it's
because I don't have gcloud set up properly.

I'm copying Eric who know the most about our Chrome OS build.