[turbofan] improved move optimizer readability: MoveKey

[turbofan] improved move optimizer readability: MoveKey

MoveKey used to be a std::pair. Rather than expecting the reader to
remember which is "first" and "second", this change makes it a struct
with specific names ("source" and "destination")

BUG=

Committed: https://crrev.com/828a2df3f912ab3f971f357daa2d30d9c09e900c
Cr-Commit-Position: refs/heads/master@{#33536}

[Mircea Trofin, 2016-01-27 04:35:27]

Description was changed from

==========
[turbofan] improved move optimizer readability: MoveKey

MoveKey used to be a std::pair. Rather than expecting the reader to
remember which is "first" and "second", this change makes it a struct
with specific names ("source" and "destination")

BUG=
==========

to

==========
[turbofan] improved move optimizer readability: MoveKey

MoveKey used to be a std::pair. Rather than expecting the reader to
remember which is "first" and "second", this change makes it a struct
with specific names ("source" and "destination")

BUG=
==========

[Mircea Trofin, 2016-01-27 04:35:27]

mtrofin@chromium.org changed reviewers:
+ bmeurer@chromium.org, jarin@chromium.org

[Jarin, 2016-01-27 05:11:50]

lgtm

https://codereview.chromium.org/1641523002/diff/1/src/compiler/move-optimizer.cc
File src/compiler/move-optimizer.cc (right):

https://codereview.chromium.org/1641523002/diff/1/src/compiler/move-optimizer...
src/compiler/move-optimizer.cc:14: InstructionOperand source_;
You should not have underscores at the end for public fields in structs.

[Mircea Trofin, 2016-01-27 06:37:43]

https://codereview.chromium.org/1641523002/diff/1/src/compiler/move-optimizer.cc
File src/compiler/move-optimizer.cc (right):

https://codereview.chromium.org/1641523002/diff/1/src/compiler/move-optimizer...
src/compiler/move-optimizer.cc:14: InstructionOperand source_;
On 2016/01/27 05:11:50, Jarin wrote:
> You should not have underscores at the end for public fields in structs.

Oh! Happy to remove them! 

Some parts of the code have them, which is what got me down this path - see
PrintableInstructionOperand for instance. I suppose this is something we'd want
to clean up?

[Mircea Trofin, 2016-01-27 06:37:46]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2016-01-27 06:37:47]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1641523002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-01-27 06:37:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641523002/20001

[commit-bot: I haz the power, 2016-01-27 07:02:58]

Description was changed from

==========
[turbofan] improved move optimizer readability: MoveKey

MoveKey used to be a std::pair. Rather than expecting the reader to
remember which is "first" and "second", this change makes it a struct
with specific names ("source" and "destination")

BUG=
==========

to

==========
[turbofan] improved move optimizer readability: MoveKey

MoveKey used to be a std::pair. Rather than expecting the reader to
remember which is "first" and "second", this change makes it a struct
with specific names ("source" and "destination")

BUG=
==========

[commit-bot: I haz the power, 2016-01-27 07:02:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-27 07:03:19]

Description was changed from

==========
[turbofan] improved move optimizer readability: MoveKey

MoveKey used to be a std::pair. Rather than expecting the reader to
remember which is "first" and "second", this change makes it a struct
with specific names ("source" and "destination")

BUG=
==========

to

==========
[turbofan] improved move optimizer readability: MoveKey

MoveKey used to be a std::pair. Rather than expecting the reader to
remember which is "first" and "second", this change makes it a struct
with specific names ("source" and "destination")

BUG=

Committed: https://crrev.com/828a2df3f912ab3f971f357daa2d30d9c09e900c
Cr-Commit-Position: refs/heads/master@{#33536}
==========

[commit-bot: I haz the power, 2016-01-27 07:03:19]

Patchset 2 (id:??) landed as
https://crrev.com/828a2df3f912ab3f971f357daa2d30d9c09e900c
Cr-Commit-Position: refs/heads/master@{#33536}