Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/process/process_posix.cc

Issue 1641513004: Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/process_metrics_win.cc ('k') | base/process/process_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process/process_posix.cc
diff --git a/base/process/process_posix.cc b/base/process/process_posix.cc
index 47b0d5b11fb29bfdc49979f6314dc93a7c068d19..b6f22c1edcf7e510a72d59a3a48d857da86606cf 100644
--- a/base/process/process_posix.cc
+++ b/base/process/process_posix.cc
@@ -295,9 +295,10 @@ void Process::Close() {
#if !defined(OS_NACL_NONSFI)
bool Process::Terminate(int exit_code, bool wait) const {
- // result_code isn't supportable.
+ // exit_code isn't supportable.
DCHECK(IsValid());
- DCHECK_GT(process_, 1);
+ CHECK_GT(process_, 0);
+
bool result = kill(process_, SIGTERM) == 0;
if (result && wait) {
int tries = 60;
« no previous file with comments | « base/process/process_metrics_win.cc ('k') | base/process/process_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698