gin/modules/console.cc - Issue 1641513004: Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/console.cc

Issue 1641513004: Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/modules/console.cc

diff --git a/gin/modules/console.cc b/gin/modules/console.cc

index d172373f01df2a0a2d194bfbc866e65f17015087..3b444669ffb003195c7a872f3118951ae05b0f6f 100644

--- a/gin/modules/console.cc

+++ b/gin/modules/console.cc

@@ -25,7 +25,7 @@ void Log(Arguments* args) {

args->ThrowError();

return;

}

- std::cout << JoinString(messages, ' ') << std::endl;

+ std::cout << base::JoinString(messages, base::StringPiece(" ")) << std::endl;

viettrungluu 2016/01/28 21:32:46 You don't need to include stringpiece.h? (Isn't th

}

WrapperInfo g_wrapper_info = { kEmbedderNativeGin };