Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 16415016: Move nullable_string16.h to the string subdirectory. (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)
Modified:
7 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Move nullable_string16.h to the string subdirectory. BUG=247723 TEST=no change TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206066

Patch Set 1 #

Patch Set 2 : missed a few #

Patch Set 3 : rebase #

Patch Set 4 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -216 lines) Patch
M base/nullable_string16.h View 1 chunk +3 lines, -25 lines 0 comments Download
A + base/strings/nullable_string16.h View 2 chunks +11 lines, -3 lines 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter.h View 3 chunks +7 lines, -4 lines 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_gtk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_drag_dest_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/dom_storage_messages.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ipc/ipc_message_utils.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ipc/ipc_message_utils.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_area.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_area.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_area_unittest.cc View 1 8 chunks +8 lines, -8 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_context.h View 1 4 chunks +6 lines, -5 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_context.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/dom_storage/dom_storage_context_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_database.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/dom_storage/dom_storage_database.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_database_unittest.cc View 1 12 chunks +22 lines, -17 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_host.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_host.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M webkit/browser/dom_storage/session_storage_database.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/browser/dom_storage/session_storage_database_unittest.cc View 1 4 chunks +13 lines, -13 lines 0 comments Download
M webkit/common/dom_storage/dom_storage_map.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/common/dom_storage/dom_storage_map.cc View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M webkit/common/dom_storage/dom_storage_map_unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/common/dom_storage/dom_storage_types.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/webdropdata.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/common/webdropdata.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M webkit/renderer/dom_storage/dom_storage_cached_area.h View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/renderer/dom_storage/dom_storage_cached_area.cc View 1 2 3 5 chunks +8 lines, -7 lines 0 comments Download
M webkit/renderer/dom_storage/dom_storage_cached_area_unittest.cc View 1 2 3 5 chunks +10 lines, -9 lines 0 comments Download
M webkit/renderer/dom_storage/dom_storage_proxy.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/simple_dom_storage_system.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/support/simple_dom_storage_system.cc View 1 2 3 4 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Avi (use Gerrit)
7 years, 6 months ago (2013-06-12 18:11:59 UTC) #1
brettw
lgtm
7 years, 6 months ago (2013-06-12 18:14:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16415016/1
7 years, 6 months ago (2013-06-12 18:16:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16415016/13001
7 years, 6 months ago (2013-06-12 20:28:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16415016/13001
7 years, 6 months ago (2013-06-12 21:05:04 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=8731
7 years, 6 months ago (2013-06-12 22:09:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16415016/13001
7 years, 6 months ago (2013-06-13 02:17:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/16415016/13001
7 years, 6 months ago (2013-06-13 02:48:04 UTC) #8
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=8865
7 years, 6 months ago (2013-06-13 08:07:36 UTC) #9
Avi (use Gerrit)
7 years, 6 months ago (2013-06-13 13:47:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 manually as r206066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698