Source/core/editing/markup.cpp - Issue 16415007: Cleanup usage of CSSPropertyID and CSSValueID inside Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/markup.cpp

Issue 16415007: Cleanup usage of CSSPropertyID and CSSValueID inside Blink. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/markup.cpp

diff --git a/Source/core/editing/markup.cpp b/Source/core/editing/markup.cpp

index 4e44bf0c8c90d1cc44be86ff60b5bf31cbaa3472..c613813ebbef37f5a77d7f5c298d418332dcd772 100644

--- a/Source/core/editing/markup.cpp

+++ b/Source/core/editing/markup.cpp

@@ -472,7 +472,7 @@ static bool propertyMissingOrEqualToNone(StylePropertySet* style, CSSPropertyID

return true;

if (!value->isPrimitiveValue())

return false;

- return static_cast<CSSPrimitiveValue*>(value.get())->getIdent() == CSSValueNone;

+ return static_cast<CSSPrimitiveValue*>(value.get())->getValueID() == CSSValueNone;

}

static bool needInterchangeNewlineAfter(const VisiblePosition& v)