Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: base/BUILD.gn

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Follows rename. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/build_time.h » ('j') | base/build_time.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 946d17f3de33bde297556cba53be41b4952e4b89..80a3981ea7e2566106e6bfe1120e88d3e10de8f1 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -24,6 +24,12 @@ import("//build/config/ui.gni")
import("//build/nocompile.gni")
import("//testing/test.gni")
+declare_args() {
+ # Override this value to give a specific build date.
+ # See //base/build_time.cc for more details.
+ override_build_date = "N/A"
M-A Ruel 2016/01/30 02:58:14 What about: - By default override_build_date is s
Zachary Forman 2016/02/01 07:28:30 I like this - we could actually use a python scrip
+}
+
if (is_android) {
import("//build/config/android/rules.gni")
}
@@ -1317,6 +1323,10 @@ component("base") {
configs += [ "//build/config/compiler:optimize_max" ]
}
+ if (override_build_date != "N/A") {
+ defines += [ "BUILD_TIME=\"" + override_build_date + "\"" ]
+ }
+
allow_circular_includes_from = public_deps
}
« no previous file with comments | « no previous file | base/build_time.h » ('j') | base/build_time.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698