Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: build/config/posix/BUILD.gn

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments + fixes gyp build error. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/posix/BUILD.gn
diff --git a/build/config/posix/BUILD.gn b/build/config/posix/BUILD.gn
index b2ccacebfd9767477c883bbe5c5ff2abb3dd8557..d0ccc5015719a6ad1505883555e24d6757509acc 100644
--- a/build/config/posix/BUILD.gn
+++ b/build/config/posix/BUILD.gn
@@ -2,7 +2,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//build/config/build_metadata.gni")
import("//build/config/sysroot.gni")
assert(is_posix)
@@ -14,14 +13,7 @@ assert(is_posix)
config("runtime_library") {
if (!is_mac && sysroot != "") {
# Pass the sysroot to all C compiler variants, the assembler, and linker.
- # If we don't care about build metadata, then just set the sysroot to an
- # absolute path. Some buildbots (read: codesearch) care about this.
- # See crbug.com/580103 for some discussion of why this was necessary.
Nico 2016/02/09 22:53:49 ...won't this change regress things?
Zachary Forman 2016/02/09 23:26:23 No, because of a CL dsansome submitted a few days
- if (dont_embed_build_metadata) {
- cflags = [ "--sysroot=" + rebase_path(sysroot, root_build_dir) ]
- } else {
- cflags = [ "--sysroot=" + rebase_path(sysroot) ]
- }
+ cflags = [ "--sysroot=" + rebase_path(sysroot) ]
asmflags = cflags
ldflags = cflags

Powered by Google App Engine
This is Rietveld 408576698