Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: build/config/build_metadata.gni

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/build_metadata.gni
diff --git a/build/config/build_metadata.gni b/build/config/build_metadata.gni
index befacbc54d7079cf8b776be90e685ed62635f911..05351579e38ead9e5feea5c433e48652ad853dcc 100644
--- a/build/config/build_metadata.gni
+++ b/build/config/build_metadata.gni
@@ -5,14 +5,6 @@
import("//build/config/chrome_build.gni")
declare_args() {
- # Set to true to not store any build metadata, e.g. ifdef out all __DATE__
- # and __TIME__. Set to 0 to reenable the use of these macros in the code
- # base. See http://crbug.com/314403.
- #
- # Continue to embed build meta data in Official builds, basically the
- # time it was built.
- # TODO(maruel): This decision should be revisited because having an
- # official deterministic build has high value too but MSVC toolset can't
- # generate anything deterministic with WPO enabled AFAIK.
- dont_embed_build_metadata = !is_official_build
+ # TODO(zforman): Remove this file once nothing uses dont_embed_build_metadata.
+ dont_embed_build_metadata = false
Dirk Pranke 2016/02/09 02:46:56 I'm not aware of any GN bots that set this flag ..
}

Powered by Google App Engine
This is Rietveld 408576698