Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2910)

Unified Diff: base/build_time.h

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Go back to gn/ninja solution. Remove instances of dont_use_build_metadata. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/build_time.h
diff --git a/base/build_time.h b/base/build_time.h
index 4f0abc381336641425dab76d4f1533a0041b22bb..87a9d2eb3886faae0b67323c448bdd83c44405f3 100644
--- a/base/build_time.h
+++ b/base/build_time.h
@@ -10,17 +10,15 @@
namespace base {
-// GetBuildTime returns the time at which the current binary was built.
+// GetBuildTime returns the time at which the current binary was built,
+// rounded down to midnight at the start of the day in UTC.
//
-// This uses the __DATE__ and __TIME__ macros, which don't trigger a rebuild
-// when they change. However, official builds will always be rebuilt from
-// scratch.
+// This uses a generated file, which doesn't trigger a rebuild when the time
+// changes. It will, however, be updated whenever //build/util/LASTCHANGED
+// changes.
//
-// Also, since __TIME__ doesn't include a timezone, this value should only be
-// considered accurate to a day.
-//
-// NOTE: This function is disabled except for the official builds, by default
-// the date returned is "Sep 02 2008 08:00:00 PST".
+// This value should only be considered accurate to within a day.
+// It will always be in the past.
M-A Ruel 2016/02/09 00:14:13 It is guaranteed to be in the past in UTC.
Zachary Forman 2016/02/09 00:47:18 The time is given with respect to UTC. If you take
Time BASE_EXPORT GetBuildTime();
} // namespace base

Powered by Google App Engine
This is Rietveld 408576698