Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: base/build_time.h

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Merge Conflicts Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gyp ('k') | base/build_time.cc » ('j') | base/build_time.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/build_time.h
diff --git a/base/build_time.h b/base/build_time.h
index 4f0abc381336641425dab76d4f1533a0041b22bb..8014cf1d242815b93dddddecc1c791186de16cdb 100644
--- a/base/build_time.h
+++ b/base/build_time.h
@@ -10,17 +10,13 @@
namespace base {
-// GetBuildTime returns the time at which the current binary was built.
+// GetBuildTime returns the time at which the current binary was built,
+// rounded down to midnight at the start of the day in UTC.
//
-// This uses the __DATE__ and __TIME__ macros, which don't trigger a rebuild
-// when they change. However, official builds will always be rebuilt from
-// scratch.
+// This uses a generated file, which doesn't trigger a rebuild when the time
+// changes. However, official builds will always be built from scratch.
M-A Ruel 2016/02/04 15:24:13 Technically, this is not 100% true. Adding Anthony
laforge 2016/02/04 15:50:19 That's true for our full release builds, however f
Zachary Forman 2016/02/04 22:39:26 Do you have any suggestion as to how you'd like co
//
-// Also, since __TIME__ doesn't include a timezone, this value should only be
-// considered accurate to a day.
-//
-// NOTE: This function is disabled except for the official builds, by default
-// the date returned is "Sep 02 2008 08:00:00 PST".
+// This value should only be considered accurate to within a day.
Time BASE_EXPORT GetBuildTime();
} // namespace base
« no previous file with comments | « base/base.gyp ('k') | base/build_time.cc » ('j') | base/build_time.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698