Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2811)

Unified Diff: base/base.gyp

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed bad input Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index dc484f4a4a62b0d2aa9804b29ba98c235dc7f7a3..ab7ec7bd181d780ac6a9c73876062e82185f107d 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -23,6 +23,7 @@
'dependencies': [
'base_debugging_flags#target',
'base_static',
+ 'base_build_date#target',
'../testing/gtest.gyp:gtest_prod',
'../third_party/modp_b64/modp_b64.gyp:modp_b64',
'third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
@@ -1096,6 +1097,30 @@
],
},
},
+ {
+ 'type': 'none',
+ 'target_name': 'base_build_date',
+ 'actions': [{
+ 'action_name': 'generate_build_date_headers',
+ 'inputs': [ '<(DEPTH)/build/write_build_date_header.py' ],
+ 'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/base/generated_build_date.h' ],
+ 'action': [
+ 'python', '<(DEPTH)/build/write_build_date_header.py',
+ '<(SHARED_INTERMEDIATE_DIR)/base/generated_build_date.h', '--<(build_type)'
+ ]
+ }],
+ 'conditions': [
+ [ 'buildtype == "Official"', {
+ 'variables': {
+ 'build_type': '--official'
+ }
+ }, {
+ 'variables': {
+ 'build_type': '--official'
M-A Ruel 2016/02/01 17:52:28 --default ?
Zachary Forman 2016/02/02 06:30:38 Oops - good catch!
+ }
+ }],
+ ]
+ },
],
'conditions': [
['OS=="ios" and "<(GENERATOR)"=="ninja"', {

Powered by Google App Engine
This is Rietveld 408576698