Improve the error message when an import fails.

Improve the error message when an import fails.

BUG=
R=iposva@google.com

Committed: https://github.com/dart-lang/sdk/commit/250773cb651beec1a61e126a6c0756aace9c19ca

[turnidge, 2016-01-29 23:10:41]

turnidge@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2016-01-29 23:33:29]

LGTM -ip

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart#ne...
runtime/bin/builtin.dart:389: print("Wrapped error is $e");
Don't think this is needed.

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart#ne...
runtime/bin/builtin.dart:392: (e is _LoadError) ? e : new _LoadError(req,
e.toString());
Put back on one line.

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart#ne...
runtime/bin/builtin.dart:590: // Register a dummy load request and fail to load
it.
// Register a dummy load request so we can fail to load it.

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart#ne...
runtime/bin/builtin.dart:612: // Register a dummy load request and fail to load
it.
ditto

[turnidge, 2016-01-30 00:29:00]

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart#ne...
runtime/bin/builtin.dart:389: print("Wrapped error is $e");
On 2016/01/29 23:33:29, Ivan Posva wrote:
> Don't think this is needed.

Done.

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart#ne...
runtime/bin/builtin.dart:392: (e is _LoadError) ? e : new _LoadError(req,
e.toString());
On 2016/01/29 23:33:29, Ivan Posva wrote:
> Put back on one line.

Done.

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart#ne...
runtime/bin/builtin.dart:590: // Register a dummy load request and fail to load
it.
On 2016/01/29 23:33:29, Ivan Posva wrote:
> // Register a dummy load request so we can fail to load it.

Done.

https://codereview.chromium.org/1641383003/diff/1/runtime/bin/builtin.dart#ne...
runtime/bin/builtin.dart:612: // Register a dummy load request and fail to load
it.
On 2016/01/29 23:33:29, Ivan Posva wrote:
> ditto

Done.

[turnidge, 2016-01-30 00:30:11]

Description was changed from

==========
Improve the error message when an import fails.

BUG=
==========

to

==========
Improve the error message when an import fails.

BUG=
R=iposva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/250773cb651beec1a61e126a6c0756aace9c19ca
==========

[turnidge, 2016-01-30 00:30:12]

Committed patchset #2 (id:20001) manually as
250773cb651beec1a61e126a6c0756aace9c19ca (presubmit successful).