Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 164137: Modified the toolbar button handlers so that the handlers can revert the locati... (Closed)

Created:
11 years, 4 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Modified the toolbar button handlers so that the handlers can revert the location bar when the button pressed is RELOAD, FORWARD, or BACK. Note that this change does not handle F5 nor Ctrl-r key presses. That's intentional. Please see the comment #7 by pkasting in http://crbug.com/15464 . Windows change: http://codereview.chromium.org/155908 Mac change: http://codereview.chromium.org/164145 BUG=18710 TEST=The same as http://codereview.chromium.org/155908 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23016

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/gtk/browser_toolbar_gtk.cc View 1 2 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
Evan, can you review this?
11 years, 4 months ago (2009-08-08 01:43:22 UTC) #1
Evan Stade
I think it would be cleaner if you didn't change the BackForwardButtonGtk class and instead ...
11 years, 4 months ago (2009-08-10 18:04:38 UTC) #2
Yusuke Sato
On 2009/08/10 18:04:38, Evan Stade wrote: > I think it would be cleaner if you ...
11 years, 4 months ago (2009-08-11 02:26:46 UTC) #3
Evan Stade
11 years, 4 months ago (2009-08-11 03:51:56 UTC) #4
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698