Adds bot_update to depot_tools.

Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient recipe modules from build. This should allow for recipes to run on swarming.

Also moves the recipe stuff into the infra folder.

bot_update has been modified. See full diff at https://paste.googleplex.com/4969207737352192

TBR=phajdan.jr@chromium.org

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298490

[martiniss, 2016-01-29 23:13:56]

The CQ bit was checked by martiniss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 23:14:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641363002/40001

[martiniss, 2016-01-29 23:14:17]

martiniss@chromium.org changed reviewers:
+ iannucci@chromium.org

[martiniss, 2016-01-29 23:14:18]

PTAL

[commit-bot: I haz the power, 2016-01-29 23:16:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 23:16:01]

Dry run: This issue passed the CQ dry run.

[martiniss, 2016-01-30 00:17:54]

Description was changed from

==========
Cleans up the bot_update module.

This should allow for recipes to run on swarming.

BUG=
==========

to

==========
Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient
recipe modules from build. This should allow for recipes to run on swarming.

BUG=
==========

[iannucci, 2016-01-30 00:40:18]

lgtm, though do we have to have it as a root directory? Can we put it under the
'infra' toplevel directory instead?

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/bot_upda...
File recipe_modules/bot_update/api.py (right):

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/bot_upda...
recipe_modules/bot_update/api.py:51: def __init__(self, *args, **kwargs):
no PROPERTIES ?

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/bot_upda...
File recipe_modules/bot_update/example.py (right):

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/bot_upda...
recipe_modules/bot_update/example.py:12: def RunSteps(api):
We need to re-think these examples... in particular, we should probably make
them look like real examples. Some folks look at these as the canonical way to
do stuff.

For now, can we switch to PROPERTIES at least?

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/bot_upda...
File recipe_modules/bot_update/resources/bot_update.py (right):

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/bot_upda...
recipe_modules/bot_update/resources/bot_update.py:1: #!/usr/bin/env python
I'm not sure that the __init__ file is needed?


I assume that this file is a copypasta?

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/depot_to...
File recipe_modules/depot_tools/example.py (right):

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/depot_to...
recipe_modules/depot_tools/example.py:11: api.python('gclient help',
api.depot_tools.gclient_py, ['--help'])
TODO: we should probably hide the path to the python script and instead do
everything via a __call__ or helper methods. It will make things easier to
refactor later.

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/gclient/...
File recipe_modules/gclient/api.py (right):

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/gclient/...
recipe_modules/gclient/api.py:31: properties.get('revision') or
as part of luci/milo/etc. we really need to come up with a set of well-defined
properties (like a src manifest input+output format, standard patching property
names and rules, etc.). There's so much cruft, it's ridiculous.

One way to combat this is to start pushing junk downstream; instead of having
this crap here in the upstream, force the downstream implementations to have
their own copy. Simultaneously introduce a well-defined gold standard in
upstream. Then downstreams can independently rely on the gold standard instead,
and eventually the cruft is gone.

Keeping it upstream (here in depot_tools) means that downstream folks have no
incentive to fix the weirdness (b/c it's supported by upstream!). Meh.

/rant, no action here, maybe a TODO or start a craplist of all the crappy crap
we need to push on.

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/gclient/...
recipe_modules/gclient/api.py:35: def jsonish_to_python(spec, is_top=False):
wait we have 2 copies of this thing? there's one in bot_update too...

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/rietveld...
File recipe_modules/rietveld/api.py (right):

https://codereview.chromium.org/1641363002/diff/40001/recipe_modules/rietveld...
recipe_modules/rietveld/api.py:37: }
more crappy crap

[martiniss, 2016-01-30 04:56:20]

martiniss@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[martiniss, 2016-01-30 04:56:32]

Description was changed from

==========
Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient
recipe modules from build. This should allow for recipes to run on swarming.

BUG=
==========

to

==========
Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient
recipe modules from build. This should allow for recipes to run on swarming.

TBR=phajdan.jr@chromium.org

BUG=
==========

[martiniss, 2016-01-30 04:56:47]

Description was changed from

==========
Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient
recipe modules from build. This should allow for recipes to run on swarming.

TBR=phajdan.jr@chromium.org

BUG=
==========

to

==========
Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient
recipe modules from build. This should allow for recipes to run on swarming.

Also moves the recipe stuff into the infra folder.

TBR=phajdan.jr@chromium.org

BUG=
==========

[martiniss, 2016-01-30 05:14:47]

Description was changed from

==========
Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient
recipe modules from build. This should allow for recipes to run on swarming.

Also moves the recipe stuff into the infra folder.

TBR=phajdan.jr@chromium.org

BUG=
==========

to

==========
Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient
recipe modules from build. This should allow for recipes to run on swarming.

Also moves the recipe stuff into the infra folder.

bot_update has been modified. See full diff at
https://paste.googleplex.com/4969207737352192

TBR=phajdan.jr@chromium.org

BUG=
==========

[martiniss, 2016-01-30 05:15:53]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-01-30 05:15:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1641363002/#ps100001
(title: "Final cleanups.")

[commit-bot: I haz the power, 2016-01-30 05:16:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641363002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641363002/100001

[commit-bot: I haz the power, 2016-01-30 05:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 05:20:33]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)

[martiniss, 2016-01-30 05:56:54]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-01-30 05:56:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1641363002/#ps120001
(title: "Rebase and expectations.")

[commit-bot: I haz the power, 2016-01-30 05:57:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641363002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641363002/120001

[commit-bot: I haz the power, 2016-01-30 05:59:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 05:59:17]

Failed to apply patch for infra/recipe_modules/depot_tools/api.py:
While running svn propset svn:eol-style LF
infra/recipe_modules/depot_tools/api.py --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  A         infra/recipe_modules/depot_tools/api.py
  Copied recipe_modules/depot_tools/api.py ->
infra/recipe_modules/depot_tools/api.py
  patching file infra/infra/recipe_modules/depot_tools/api.py (renamed from
infra/recipe_modules/depot_tools/api.py)
  svn: E000002: Can't open file
'/b/infra_internal/commit_queue/workdir/depot_tools/infra/recipe_modules/depot_tools/api.py':
No such file or directory

Patch:   NR 
recipe_modules/depot_tools/api.py->infra/recipe_modules/depot_tools/api.py
Index: infra/recipe_modules/depot_tools/api.py
diff --git a/recipe_modules/depot_tools/api.py
b/infra/recipe_modules/depot_tools/api.py
similarity index 79%
rename from recipe_modules/depot_tools/api.py
rename to infra/recipe_modules/depot_tools/api.py
index
3685330e9035d949d9101f999f89d68de89ed148..564ec1a3c4da89a495244ebf9a157c7478e9932d
100644
--- a/recipe_modules/depot_tools/api.py
+++ b/infra/recipe_modules/depot_tools/api.py
@@ -10,3 +10,7 @@ class DepotToolsApi(recipe_api.RecipeApi):
   @property
   def gclient_py(self):
     return self.package_resource('gclient.py')
+
+  @property
+  def presubmit_support(self):
+    return self.package_resource('presubmit_support.py')

[commit-bot: I haz the power, 2016-01-30 05:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[martiniss, 2016-01-30 06:06:52]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-01-30 06:06:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641363002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641363002/120001

[commit-bot: I haz the power, 2016-01-30 06:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 06:09:01]

Failed to apply patch for infra/recipe_modules/depot_tools/api.py:
While running svn propset svn:eol-style LF
infra/recipe_modules/depot_tools/api.py --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  A         infra/recipe_modules/depot_tools/api.py
  Copied recipe_modules/depot_tools/api.py ->
infra/recipe_modules/depot_tools/api.py
  patching file infra/infra/recipe_modules/depot_tools/api.py (renamed from
infra/recipe_modules/depot_tools/api.py)
  svn: E000002: Can't open file
'/b/infra_internal/commit_queue/workdir/depot_tools/infra/recipe_modules/depot_tools/api.py':
No such file or directory

Patch:   NR 
recipe_modules/depot_tools/api.py->infra/recipe_modules/depot_tools/api.py
Index: infra/recipe_modules/depot_tools/api.py
diff --git a/recipe_modules/depot_tools/api.py
b/infra/recipe_modules/depot_tools/api.py
similarity index 79%
rename from recipe_modules/depot_tools/api.py
rename to infra/recipe_modules/depot_tools/api.py
index
3685330e9035d949d9101f999f89d68de89ed148..564ec1a3c4da89a495244ebf9a157c7478e9932d
100644
--- a/recipe_modules/depot_tools/api.py
+++ b/infra/recipe_modules/depot_tools/api.py
@@ -10,3 +10,7 @@ class DepotToolsApi(recipe_api.RecipeApi):
   @property
   def gclient_py(self):
     return self.package_resource('gclient.py')
+
+  @property
+  def presubmit_support(self):
+    return self.package_resource('presubmit_support.py')

[martiniss, 2016-01-30 06:38:57]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-01-30 06:39:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641363002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641363002/120001

[commit-bot: I haz the power, 2016-01-30 06:41:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 06:41:26]

Failed to apply patch for infra/recipe_modules/depot_tools/api.py:
While running svn propset svn:eol-style LF
infra/recipe_modules/depot_tools/api.py --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  A         infra/recipe_modules/depot_tools/api.py
  Copied recipe_modules/depot_tools/api.py ->
infra/recipe_modules/depot_tools/api.py
  patching file infra/infra/recipe_modules/depot_tools/api.py (renamed from
infra/recipe_modules/depot_tools/api.py)
  svn: E000002: Can't open file
'/b/infra_internal/commit_queue/workdir/depot_tools/infra/recipe_modules/depot_tools/api.py':
No such file or directory

Patch:   NR 
recipe_modules/depot_tools/api.py->infra/recipe_modules/depot_tools/api.py
Index: infra/recipe_modules/depot_tools/api.py
diff --git a/recipe_modules/depot_tools/api.py
b/infra/recipe_modules/depot_tools/api.py
similarity index 79%
rename from recipe_modules/depot_tools/api.py
rename to infra/recipe_modules/depot_tools/api.py
index
3685330e9035d949d9101f999f89d68de89ed148..564ec1a3c4da89a495244ebf9a157c7478e9932d
100644
--- a/recipe_modules/depot_tools/api.py
+++ b/infra/recipe_modules/depot_tools/api.py
@@ -10,3 +10,7 @@ class DepotToolsApi(recipe_api.RecipeApi):
   @property
   def gclient_py(self):
     return self.package_resource('gclient.py')
+
+  @property
+  def presubmit_support(self):
+    return self.package_resource('presubmit_support.py')

[commit-bot: I haz the power, 2016-01-30 06:41:27]

The CQ bit was unchecked by commit-bot@chromium.org

[martiniss, 2016-01-30 07:12:29]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-01-30 07:12:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641363002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641363002/120001

[commit-bot: I haz the power, 2016-01-30 07:15:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 07:15:03]

Failed to apply patch for infra/recipe_modules/depot_tools/api.py:
While running svn propset svn:eol-style LF
infra/recipe_modules/depot_tools/api.py --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  A         infra/recipe_modules/depot_tools/api.py
  Copied recipe_modules/depot_tools/api.py ->
infra/recipe_modules/depot_tools/api.py
  patching file infra/infra/recipe_modules/depot_tools/api.py (renamed from
infra/recipe_modules/depot_tools/api.py)
  svn: E000002: Can't open file
'/b/infra_internal/commit_queue/workdir/depot_tools/infra/recipe_modules/depot_tools/api.py':
No such file or directory

Patch:   NR 
recipe_modules/depot_tools/api.py->infra/recipe_modules/depot_tools/api.py
Index: infra/recipe_modules/depot_tools/api.py
diff --git a/recipe_modules/depot_tools/api.py
b/infra/recipe_modules/depot_tools/api.py
similarity index 79%
rename from recipe_modules/depot_tools/api.py
rename to infra/recipe_modules/depot_tools/api.py
index
3685330e9035d949d9101f999f89d68de89ed148..564ec1a3c4da89a495244ebf9a157c7478e9932d
100644
--- a/recipe_modules/depot_tools/api.py
+++ b/infra/recipe_modules/depot_tools/api.py
@@ -10,3 +10,7 @@ class DepotToolsApi(recipe_api.RecipeApi):
   @property
   def gclient_py(self):
     return self.package_resource('gclient.py')
+
+  @property
+  def presubmit_support(self):
+    return self.package_resource('presubmit_support.py')

[martiniss, 2016-01-30 07:30:04]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-01-30 07:30:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641363002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641363002/120001

[commit-bot: I haz the power, 2016-01-30 07:32:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 07:32:26]

Failed to apply patch for infra/recipe_modules/depot_tools/api.py:
While running svn propset svn:eol-style LF
infra/recipe_modules/depot_tools/api.py --config-dir
/b/infra_internal/commit_queue/subversion_config --non-interactive;
  A         infra/recipe_modules/depot_tools/api.py
  Copied recipe_modules/depot_tools/api.py ->
infra/recipe_modules/depot_tools/api.py
  patching file infra/infra/recipe_modules/depot_tools/api.py (renamed from
infra/recipe_modules/depot_tools/api.py)
  svn: E000002: Can't open file
'/b/infra_internal/commit_queue/workdir/depot_tools/infra/recipe_modules/depot_tools/api.py':
No such file or directory

Patch:   NR 
recipe_modules/depot_tools/api.py->infra/recipe_modules/depot_tools/api.py
Index: infra/recipe_modules/depot_tools/api.py
diff --git a/recipe_modules/depot_tools/api.py
b/infra/recipe_modules/depot_tools/api.py
similarity index 79%
rename from recipe_modules/depot_tools/api.py
rename to infra/recipe_modules/depot_tools/api.py
index
3685330e9035d949d9101f999f89d68de89ed148..564ec1a3c4da89a495244ebf9a157c7478e9932d
100644
--- a/recipe_modules/depot_tools/api.py
+++ b/infra/recipe_modules/depot_tools/api.py
@@ -10,3 +10,7 @@ class DepotToolsApi(recipe_api.RecipeApi):
   @property
   def gclient_py(self):
     return self.package_resource('gclient.py')
+
+  @property
+  def presubmit_support(self):
+    return self.package_resource('presubmit_support.py')

[commit-bot: I haz the power, 2016-01-30 07:32:27]

The CQ bit was unchecked by commit-bot@chromium.org

[martiniss, 2016-01-30 20:06:36]

The CQ bit was checked by martiniss@chromium.org

[martiniss, 2016-01-30 20:06:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1641363002/#ps140001
(title: "Don't delete the old files in this CL.")

[commit-bot: I haz the power, 2016-01-30 20:06:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641363002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641363002/140001

[commit-bot: I haz the power, 2016-01-30 20:09:01]

Description was changed from

==========
Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient
recipe modules from build. This should allow for recipes to run on swarming.

Also moves the recipe stuff into the infra folder.

bot_update has been modified. See full diff at
https://paste.googleplex.com/4969207737352192

TBR=phajdan.jr@chromium.org

BUG=
==========

to

==========
Adds bot_update to depot_tools.

This CL imports the bot_update script, along with the bot_update and gclient
recipe modules from build. This should allow for recipes to run on swarming.

Also moves the recipe stuff into the infra folder.

bot_update has been modified. See full diff at
https://paste.googleplex.com/4969207737352192

TBR=phajdan.jr@chromium.org

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298490
==========

[commit-bot: I haz the power, 2016-01-30 20:09:02]

Committed patchset #8 (id:140001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298490

[luqui, 2016-02-01 23:57:47]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1651323002/ by luqui@chromium.org.

The reason for reverting is: Exposed recipe engine bug with ambiguous names,
causing roller blockage..