chrome/browser/chromeos/arc/arc_service_launcher.cc - Issue 1641353003: GpuArcVideoService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_service_launcher.cc

Issue 1641353003: GpuArcVideoService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@arc-4-owen-ArcGpuVideoDecodeAccelerator

Patch Set: address dcheng's comments (uint32) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/chrome_main_delegate.cc ('k') | chrome/browser/chromeos/arc/gpu_arc_video_service_host.h » ('j') | components/arc/common/video_accelerator.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/arc/arc_service_launcher.cc

diff --git a/chrome/browser/chromeos/arc/arc_service_launcher.cc b/chrome/browser/chromeos/arc/arc_service_launcher.cc

index 543c7770aa01936762af5b35efe92a6d3508244c..0455e28ab6fae925e1b21197830c4e93e41c36b6 100644

--- a/chrome/browser/chromeos/arc/arc_service_launcher.cc

+++ b/chrome/browser/chromeos/arc/arc_service_launcher.cc

@@ -9,6 +9,7 @@

#include "chrome/browser/chromeos/arc/arc_intent_helper_bridge.h"

#include "chrome/browser/chromeos/arc/arc_policy_bridge.h"

#include "chrome/browser/chromeos/arc/arc_process_service.h"

+#include "chrome/browser/chromeos/arc/gpu_arc_video_service_host.h"

#include "chromeos/dbus/dbus_thread_manager.h"

#include "chromeos/dbus/session_manager_client.h"

#include "components/arc/arc_bridge_service.h"

@@ -30,8 +31,10 @@ void ArcServiceLauncher::Initialize() {

new ArcPolicyBridge(arc_service_manager_->arc_bridge_service())));

arc_service_manager_->AddService(make_scoped_ptr(

new ArcProcessService(arc_service_manager_->arc_bridge_service())));

+ arc_service_manager_->AddService(make_scoped_ptr(

dcheng 2016/04/10 05:01:23 BTW chromeos directory uses base::WrapUnique and s

kcwu 2016/04/11 04:07:32 Thanks for the information, I didn't know WrapUniq

+ new GpuArcVideoServiceHost(arc_service_manager_->arc_bridge_service())));

- // Detect availiability.

+ // Detect availability.

chromeos::SessionManagerClient* session_manager_client =

chromeos::DBusThreadManager::Get()->GetSessionManagerClient();

session_manager_client->CheckArcAvailability(base::Bind(