components/arc/common/video.mojom - Issue 1641353003: GpuArcVideoService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/common/video.mojom

Issue 1641353003: GpuArcVideoService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@arc-4-owen-ArcGpuVideoDecodeAccelerator

Patch Set: addressed Owen's comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/arc/common/video.mojom

diff --git a/components/arc/common/video.mojom b/components/arc/common/video.mojom

index b21a1dbc4a62a3951bcf45f2441c67f1adde745b..c61f4f138f5447fe2296e263cda9657d83a1a949 100644

--- a/components/arc/common/video.mojom

+++ b/components/arc/common/video.mojom

@@ -5,8 +5,13 @@

module arc;

interface VideoHost {

- // Notifies Chrome a request for ipc channel of video acceleration.

- OnRequestArcVideoAcceleratorChannel() => (handle channel_handle);

+ // Requests an ipc channel from Chrome to be used in the video accelerator.

+ // |pid| is the id of mojo child process.

+ // Replys |channel_handle| of mojo initial message pipe and |token| for

Luis Héctor Chávez 2016/03/16 19:07:55 nit: s/Replys/Replies with/

kcwu 2016/03/17 08:07:44 Done.

+ // creating the client end of VideoAcceleratorService message pipe.

+ // Replys invalid handle and empty token if any failure.

+ OnRequestArcVideoAcceleratorChannel(uint32 pid) => (handle channel_handle,

+ string token);

};

interface VideoInstance {

« chrome/gpu/gpu_arc_video_service.cc ('K') | « components/arc/BUILD.gn ('k') | components/arc/common/video_accelerator.mojom » ('j') | no next file with comments »