A Chrome-side fix for Issue 18232....

A Chrome-side fix for Issue 18232.
This change enables the code which displays a context menu when Chrome receives a key event for a menu key or control+F10 keys also on Linux. Even though this change makes Chrome display a context menu when we type control+F10 keys, it cannot make Chrome display a context menu when we type a menu key because WebKit maps a GDK_Menu to a VKEY_MENU. To fix this problem, we need to change WebKit to map a GDK_Menu to a VKEY_APP. 

BUG=18232
"[Linux] Menu key doesn't work"
TEST=Press a menu key (or control+F10 keys), and verify a context menu is displayed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22910

[Hironori Bono, 2009-08-07 07:43:20]

Thank you for your review in advance.
I'm going to file a bug to webkit.org and send a webkit fix for the problem
about GDK_Menu.

Regards,

Hironori Bono

[Evan Stade, 2009-08-07 18:12:30]

LGTM!

http://codereview.chromium.org/164131/diff/1/2
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/164131/diff/1/2#newcode622
Line 622: // TODO(pinkerton): figure out these keycodes on non-windows
this comment looks obsolete. Can you ping pinkerton to make sure that we don't
want it on mac? If we do want it on mac it would be nice to file a crbug.com bug
about it.

[Evan Stade, 2009-08-07 18:13:13]

pinkerton: do we want the context menu to popup on menu key/ctrl+f10 on mac?

[Avi (use Gerrit), 2009-08-07 18:18:08]

On 2009/08/07 18:13:13, Evan Stade wrote:
> pinkerton: do we want the context menu to popup on menu key/ctrl+f10 on mac?

Pink is out getting married or something like that. I'll field the question. No.
There is no concept of a menu key on the Mac. Don't implement this for the Mac.

Avi

[Evan Stade, 2009-08-07 18:20:09]

ok awesome. There you have it, delete the comment.