Moved theme related state from BrowserInstantController to InstantService.

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index d6d87e3271712cdc748574392cb49b53e4b21e37..e79db0706501cd2faee094b46204f8ad5f63a887 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -482,6 +482,10 @@ Browser::~Browser() {
   // is destroyed to make sure the chrome.windows.onRemoved event is sent.
   extension_window_controller_.reset();
 
+  // Destroy BrowserInstantController before the incongnito profile is destroyed
+  // because the InstantController destructor depends on this profile.
+  instant_controller_.reset();

[Peter Kasting, 2013/06/21 02:33:30]

Check with erg/rlp on whether there's a better way to indicate this dependency
within your class itself.  (Maybe we should make the instant controller a
profile-keyed service or something.)

[kmadhusu, 2013/06/21 02:49:39]

rlp@: Is there any better way to indicate this dependency?

[rpetterson, 2013/06/21 06:19:06]

Are BrowserInstantControllers per profile or per browser? If it's the former,
then yes, it should be a browser_context keyed service. If not, then this is
probably the appropriate place for this.

[kmadhusu, 2013/06/21 15:45:45]

BrowserInstantController is instantiated per browser and not per profile.

+
   if (profile_->IsOffTheRecord() &&
       !BrowserList::IsOffTheRecordSessionActiveForProfile(profile_)) {
     // An incognito profile is no longer needed, this indirectly frees