Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1641213002: Revert of Disable deprecated Skia xfermodes (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
Reviewers:
f(malita), reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable deprecated Skia xfermodes (patchset #1 id:1 of https://codereview.chromium.org/1644703002/ ) Reason for revert: Going to go a different direction with this. Original issue's description: > Disable deprecated Skia xfermodes > > This is a companion to https://codereview.chromium.org/1645633003/ (Hide SkPixelXorXfermode from Chrome) > > Committed: https://crrev.com/583be684fbad6f0c013ebe7e7b186c589386a926 > Cr-Commit-Position: refs/heads/master@{#371905} TBR=reed@google.com,fmalita@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/bb669dba2530ecd4f187c964e4fb933c9e423004 Cr-Commit-Position: refs/heads/master@{#372151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
robertphillips
Created Revert of Disable deprecated Skia xfermodes
4 years, 10 months ago (2016-01-28 14:41:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641213002/1
4 years, 10 months ago (2016-01-28 14:41:31 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2016-01-28 14:41:32 UTC) #4
f(malita)
lgtm
4 years, 10 months ago (2016-01-28 20:24:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641213002/1
4 years, 10 months ago (2016-01-28 20:24:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 20:26:07 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 20:27:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb669dba2530ecd4f187c964e4fb933c9e423004
Cr-Commit-Position: refs/heads/master@{#372151}

Powered by Google App Engine
This is Rietveld 408576698